After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 711423 - Allow dynamic type registration of generated dbus proxy classes
Allow dynamic type registration of generated dbus proxy classes
Status: RESOLVED FIXED
Product: vala
Classification: Core
Component: D-Bus
unspecified
Other All
: Normal normal
: ---
Assigned To: Vala maintainers
Vala maintainers
: 661361 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2013-11-04 17:01 UTC by jessevdk@gmail.com
Modified: 2013-11-05 08:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Allow dynamic type registration of generated dbus proxy classes (3.05 KB, patch)
2013-11-04 17:01 UTC, jessevdk@gmail.com 		none Details | Review
Allow dynamic type registration of generated dbus proxy classes (4.71 KB, patch)
2013-11-04 18:30 UTC, jessevdk@gmail.com 		none Details | Review
Allow dynamic type registration of generated dbus proxy classes (4.79 KB, patch)
2013-11-04 21:27 UTC, jessevdk@gmail.com 		none Details | Review
Allow dynamic type registration of generated dbus proxy classes (4.79 KB, patch)
2013-11-04 21:28 UTC, jessevdk@gmail.com 		committed Details | Review

Description jessevdk@gmail.com 2013-11-04 17:01:53 UTC 
Generate code for dynamic type registration of dbus proxy classes
when generating code for a plugin.
Comment 1 jessevdk@gmail.com 2013-11-04 17:01:55 UTC 
Created attachment 258940 [details] [review]
Allow dynamic type registration of generated dbus proxy classes
Comment 2 jessevdk@gmail.com 2013-11-04 18:30:56 UTC 
Created attachment 258948 [details] [review]
Allow dynamic type registration of generated dbus proxy classes
Comment 3 Luca Bruno 2013-11-04 20:03:46 UTC 
Review of attachment 258948 [details] [review]:

::: codegen/valaccodemethodmodule.vala
@@ +268,3 @@
 		ccode.add_expression (register_call);
+
+		string? dbus_name = GDBusModule.get_dbus_name(type_symbol);

Shouldn't we ensure that type_symbol is an Interface?
Comment 4 Luca Bruno 2013-11-04 20:04:13 UTC 
*** Bug 661361 has been marked as a duplicate of this bug. ***
Comment 5 jessevdk@gmail.com 2013-11-04 21:27:51 UTC 
Created attachment 258960 [details] [review]
Allow dynamic type registration of generated dbus proxy classes
Comment 6 jessevdk@gmail.com 2013-11-04 21:28:10 UTC 
Created attachment 258961 [details] [review]
Allow dynamic type registration of generated dbus proxy classes
Comment 7 Luca Bruno 2013-11-04 21:47:40 UTC 
Review of attachment 258961 [details] [review]:

Ok as long as it's been tested. Thanks.
Comment 8 Luca Bruno 2013-11-05 08:47:07 UTC 
commit b3d144251e7aaeb33ef5af1fa98b05bda4672a47
Author: Jesse van den Kieboom <jessevdk@gmail.com>
Date:   Mon Nov 4 18:00:15 2013 +0100

    Allow dynamic type registration of generated dbus proxy classes
    
    https://bugzilla.gnome.org/show_bug.cgi?id=711423