After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 711294 - Gnucash repeatedly ask associated income account when import qfx file
Gnucash repeatedly ask associated income account when import qfx file
Status: VERIFIED FIXED
Product: GnuCash
Classification: Other
Component: Import - OFX
unspecified
Other All
: Normal normal
: ---
Assigned To: gnucash-import-maint
gnucash-import-maint
Depends on:
Blocks:
 
 
Reported: 2013-11-02 15:56 UTC by Kuang-che Wu
Modified: 2018-06-29 23:20 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Kuang-che Wu 2013-11-02 15:56:53 UTC 
When import qfx file, gnucash will ask for associated income account for a stock account. It should record the result and not ask again. But it didn't -- it will ask every time.

The relevant lines are in gnc-ofx-kvp.c, gnc_ofx_kvp_set_assoc_account().

    xaccAccountBeginEdit(investment_account);
    kvp_frame_set_slot_nc(acc_frame, KEY_ASSOC_INCOME_ACCOUNT,
                          kvp_val);
    force_account_dirty(investment_account);
    xaccAccountCommitEdit(investment_account);

force_account_dirty() is actually no-op (see Bug 665998). As r21740 and r21753, following change could fix the problem:

-    force_account_dirty(investment_account);
+    qof_instance_set_dirty(QOF_INSTANCE (investment_account));

(I haven't tested this myself due to my laziness to build gnucash on windows)

This should affect at least gnucash 2.4 and 2.5.
Comment 1 Geert Janssens 2013-11-04 21:25:32 UTC 
Thank you for your patch, although I almost hadn't found it inlined in the report.

I have committed it in r23380. Can you verify this fixes the issue by installing tomorrow's nightly build [1] (or any more recent build) ?

Thank you.

[1] http://code.gnucash.org/builds/win32/trunk/
Comment 2 Kuang-che Wu 2013-11-05 14:57:00 UTC 
Verified with nightly build. It works.
Thanks.
Comment 3 John Ralls 2018-06-29 23:20:47 UTC 
GnuCash bug tracking has moved to a new Bugzilla host. This bug has been copied to https://bugs.gnucash.org/show_bug.cgi?id=711294. Please update any external references or bookmarks.