After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 711247 - Progress callbacks don't work with try_ methods
Progress callbacks don't work with try_ methods
Status: RESOLVED FIXED
Product: gvfs
Classification: Core
Component: daemon
git master
Other Linux
: Normal normal
: ---
Assigned To: gvfs-maint
gvfs-maint
Depends on:
Blocks: 523015
 
 
Reported: 2013-11-01 07:56 UTC by Ross Lagerwall
Modified: 2013-11-14 08:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
daemon: Make progress callbacks work with try methods (4.94 KB, patch)
2013-11-01 08:02 UTC, Ross Lagerwall 		accepted-commit_now Details | Review

Description Ross Lagerwall 2013-11-01 07:56:14 UTC 
Currently for each job type that implements progress callbacks, the progress_proxy is unref'd immediately after the backend's try method has run. This means that if the backend has an asynchronous callback which updates the progress, it doesn't work because the progress_proxy has been removed.
Comment 1 Ross Lagerwall 2013-11-01 08:02:38 UTC 
Created attachment 258717 [details] [review]
daemon: Make progress callbacks work with try methods

Before, for each job type that implements progress callbacks, the
progress_proxy was being unref'd immediately after the backend's try or
run method had run.  This means that if the backend had an asynchronous
callback which updated the progress, it wouldn't work because the
progress_proxy had been removed.

Fix this by unrefing the progress_proxy in the GVfsJobProgress class's
finalize method.
Comment 2 Alexander Larsson 2013-11-14 07:57:24 UTC 
Review of attachment 258717 [details] [review]:

Looks good to me.
Comment 3 Ross Lagerwall 2013-11-14 08:33:23 UTC 
Pushed to master as e355526f0c6c00bbb7593d02accd4075c4da800f. Thanks!