GNOME Bugzilla – Bug 711184
Patches to run in gnome-continuous
Last modified: 2013-10-31 01:16:14 UTC
The NumPy patch is a hack, comments/suggestions appreciated. Hopefully you guys are OK with it being a soft dependency; it's only a few lines of code. The other two patches should be good, but let me know what you think!
Created attachment 258622 [details] [review] 0001-Drop-dependency-on-PyXDG-use-GLib-instead.patch
Created attachment 258623 [details] [review] 0002-Attempt-to-make-NumPy-a-soft-dependency-again.patch
Created attachment 258624 [details] [review] 0003-Drop-use-of-old-glib-module.patch
Created attachment 258625 [details] [review] updated xdg patch Ooops, a quick self-review on patch 1 caught an obvious bug in xdg_data_home(). Should be fixed now.
Review of attachment 258625 [details] [review]: I guess you tested, in which case, this patch looks right to me.
Review of attachment 258623 [details] [review]: Actually I had forgoten that we now depend on NumPy for the waveform generator, I think we do want it to be a hard dep rather than making it a soft now as waveform is a key feature of Pitivi. Is that really an issue for you?
Review of attachment 258624 [details] [review]: Indeed, we should not use that at all!
(In reply to comment #6) > Review of attachment 258623 [details] [review]: > > Actually I had forgoten that we now depend on NumPy for the waveform generator, > I think we do want it to be a hard dep rather than making it a soft now as > waveform is a key feature of Pitivi. Is that really an issue for you? The goal of the system is to produce a small, well tested core operating system using GNOME technologies (i.e. revolve around GLib/GTK+), that can then be combined into larger collections such as Debian and Red Hat Enterprise Linux. There's nothing *wrong* with NumPy, but I want to keep the scope of the system small; there's too many duplicative libraries as is (like NSPR). So...let's just go with the other two patches.