After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 711052 - changes required to run against a js24 gjs.
changes required to run against a js24 gjs.
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-10-29 07:21 UTC by darkxst
Modified: 2013-10-29 20:45 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
port shell-js to c++ (1.88 KB, patch)
2013-10-29 07:22 UTC, darkxst 		needs-work Details | Review
remove direct access to jsapi (2.80 KB, patch)
2013-10-29 07:22 UTC, darkxst 		committed Details | Review
lookingGlass: Remove Memory tab and add a gc Icon to toolbar (3.88 KB, patch)
2013-10-29 07:22 UTC, darkxst 		committed Details | Review
port shell-js to c++ (1.64 KB, patch)
2013-10-29 20:31 UTC, darkxst 		committed Details | Review

Description darkxst 2013-10-29 07:21:58 UTC 
This is also safe for the current js17 gjs
Comment 1 darkxst 2013-10-29 07:22:00 UTC 
Created attachment 258413 [details] [review]
port shell-js to c++
Comment 2 darkxst 2013-10-29 07:22:03 UTC 
Created attachment 258414 [details] [review]
remove direct access to jsapi

with js24 its not possible to access jsapi directly from C code
Comment 3 darkxst 2013-10-29 07:22:07 UTC 
Created attachment 258415 [details] [review]
lookingGlass: Remove Memory tab and add a gc Icon to toolbar

With js24 it won't be possible to access gjs memory stats from C code.
Comment 4 Jasper St. Pierre (not reading bugmail) 2013-10-29 13:48:01 UTC 
Review of attachment 258413 [details] [review]:

::: src/shell-js.c
@@ +1,2 @@
 /* -*- mode: C; c-file-style: "gnu"; indent-tabs-mode: nil; -*- */
+#include <jsapi.h>

No. config.h always needs to be imported first.
Comment 5 darkxst 2013-10-29 20:31:46 UTC 
Created attachment 258483 [details] [review]
port shell-js to c++
Comment 6 Jasper St. Pierre (not reading bugmail) 2013-10-29 20:32:45 UTC 
looks good, push.
Comment 7 darkxst 2013-10-29 20:45:45 UTC 
Attachment 258414 [details] pushed as 7296bed - remove direct access to jsapi
Attachment 258415 [details] pushed as b929320 - lookingGlass: Remove Memory tab and add a gc Icon to toolbar
Attachment 258483 [details] pushed as e9fbbf4 - port shell-js to c++