After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 710996 - [next] Adapt for use of ABI versions in generated code
[next] Adapt for use of ABI versions in generated code
Status: RESOLVED FIXED
Product: folks
Classification: Platform
Component: general
git master
Other Linux
: Normal enhancement
: Unset
Assigned To: folks-maint
folks-maint
Depends on:
Blocks: 710992
 
 
Reported: 2013-10-28 10:03 UTC by Guillaume Desmottes
Modified: 2013-10-29 07:45 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Adapt for use of ABI versions in generated code (1.10 KB, patch)
2013-10-28 10:03 UTC, Guillaume Desmottes 		accepted-commit_after_freeze Details | Review
use TP_VERSION_1_0 versioning macro (1.04 KB, patch)
2013-10-28 10:03 UTC, Guillaume Desmottes 		none Details | Review
sync tests/lib/telepathy with tp-glib next (51.91 KB, patch)
2013-10-28 10:03 UTC, Guillaume Desmottes 		accepted-commit_after_freeze Details | Review
use TP_VERSION_1_0 versioning macro (1.11 KB, patch)
2013-10-28 10:43 UTC, Guillaume Desmottes 		accepted-commit_now Details | Review

Description Guillaume Desmottes 2013-10-28 10:03:26 UTC 
See https://bugs.freedesktop.org/show_bug.cgi?id=70377
Comment 1 Guillaume Desmottes 2013-10-28 10:03:48 UTC 
Created attachment 258280 [details] [review]
Adapt for use of ABI versions in generated code

See https://bugs.freedesktop.org/show_bug.cgi?id=70377 for details.
Comment 2 Guillaume Desmottes 2013-10-28 10:03:51 UTC 
Created attachment 258281 [details] [review]
use TP_VERSION_1_0 versioning macro
Comment 3 Guillaume Desmottes 2013-10-28 10:03:55 UTC 
Created attachment 258282 [details] [review]
sync tests/lib/telepathy with tp-glib next
Comment 4 Simon McVittie 2013-10-28 10:37:53 UTC 
Review of attachment 258280 [details] [review]:

I don't know how much weight my opinion carries in Folks review, but this looks good to me as soon as telepathy-glib 0.99.3 is released.
Comment 5 Simon McVittie 2013-10-28 10:38:41 UTC 
Review of attachment 258281 [details] [review]:

Looks good to me with the change below, either before or after telepathy-glib 0.99.3:

::: configure.ac
@@ +246,3 @@
 AM_CONDITIONAL([ENABLE_ZEITGEIST], [test "x$have_zeitgeist" = "xyes"])
 
 # Ignore post 0.20 deprecations

"post 1.0 deprecations", and also "post 1.0 APIs" a couple of lines down
Comment 6 Guillaume Desmottes 2013-10-28 10:43:40 UTC 
Created attachment 258286 [details] [review]
use TP_VERSION_1_0 versioning macro
Comment 7 Simon McVittie 2013-10-28 10:45:53 UTC 
Review of attachment 258282 [details] [review]:

Looks fine after 0.99.3.
Comment 8 Simon McVittie 2013-10-28 10:46:46 UTC 
Review of attachment 258286 [details] [review]:

Looks good any time to me, ask pwithnall or treitter whether I have reviewer rights for Folks :-)
Comment 9 Simon McVittie 2013-10-28 10:48:54 UTC 
Review of attachment 258280 [details] [review]:

10:47 < smcv> pwithnall, treitter: is r+ from me considered to be sufficient 
              for folks 'next', or indeed for mainstream folks branches?
10:47 < pwithnall> smcv: Yes, definitely
Comment 10 Simon McVittie 2013-10-28 10:49:17 UTC 
Review of attachment 258282 [details] [review]:

a-c_a_f
Comment 11 Simon McVittie 2013-10-28 10:49:27 UTC 
Review of attachment 258286 [details] [review]:

shipit
Comment 12 Guillaume Desmottes 2013-10-29 07:45:21 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.