After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 710935 - sftp: creating symlink can give the wrong error code if it already exists
sftp: creating symlink can give the wrong error code if it already exists
Status: RESOLVED FIXED
Product: gvfs
Classification: Core
Component: sftp backend
git master
Other Linux
: Normal normal
: ---
Assigned To: gvfs-maint
gvfs-maint
Depends on:
Blocks:
 
 
Reported: 2013-10-26 20:02 UTC by Ross Lagerwall
Modified: 2013-10-31 13:10 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
sftp: Return the correct error code on failed symlink creation (1008 bytes, patch)
2013-10-26 20:05 UTC, Ross Lagerwall 		accepted-commit_now Details | Review

Description Ross Lagerwall 2013-10-26 20:02:02 UTC 
If the the symlink name already exists, the G_IO_ERROR_EXISTS error code is not returned.
Comment 1 Ross Lagerwall 2013-10-26 20:05:37 UTC 
Created attachment 258188 [details] [review]
sftp: Return the correct error code on failed symlink creation

If the symlink path already exists, return the correct error code of
G_IO_ERROR_EXISTS.
Comment 2 Ondrej Holy 2013-10-31 12:44:46 UTC 
Review of attachment 258188 [details] [review]:

It looks good, however please remove trailing whitespace before committing...
Comment 3 Ross Lagerwall 2013-10-31 13:10:13 UTC 
Pushed to master as 38a0034. Thanks.