After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 710705 - Indicate number of users in the headerbar
Indicate number of users in the headerbar
Status: RESOLVED FIXED
Product: polari
Classification: Applications
Component: general
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: Polari maintainers
Polari maintainers
Depends on:
Blocks:
 
 
Reported: 2013-10-23 09:39 UTC by Allan Day
Modified: 2014-02-27 17:48 UTC
See Also:
GNOME target: ---
GNOME version: 3.11/3.12


Attachments
mockups (16.68 KB, image/png)
2013-10-23 09:39 UTC, Allan Day
  Details
ui: Display number of users in show-user-list button (3.69 KB, patch)
2013-10-24 15:11 UTC, Florian Müllner
none Details | Review
ui: Display number of users in show-user-list button (3.91 KB, patch)
2013-10-24 15:21 UTC, Florian Müllner
none Details | Review
screenshot (51.43 KB, image/png)
2013-10-24 15:34 UTC, William Jon McCann
  Details
ui: Display number of users in show-user-list button (5.30 KB, patch)
2014-02-25 18:58 UTC, Florian Müllner
committed Details | Review
ui: Display number of users in show-user-list button (6.25 KB, patch)
2014-02-27 17:48 UTC, Florian Müllner
none Details | Review

Description Allan Day 2013-10-23 09:39:56 UTC
Created attachment 257897 [details]
mockups

Sometimes it's useful to see how many people are in a room:

 * It tells you if you have entered the channel name incorrectly.
 * If you are in a channel with a small number of people, and want to know if people are around.

I've attached some design experiments.
Comment 1 Jakub Steiner 2013-10-23 10:20:34 UTC
I kind of favor dropping the icon completely and have it just state the number in a button (#2 without the icon). It's not obvious at first, but the icon really doesn't bring that much to the table. It's much cleaner after you're discovered what the button does.
Comment 2 Florian Müllner 2013-10-24 15:11:14 UTC
Created attachment 258027 [details] [review]
ui: Display number of users in show-user-list button

The number of users in a room is useful information (for instance
for quick judgement regarding the room's activity), which we
currently only expose inside the user list.
Replace the icon of the show-user-list button with the number of
users to make this information always available.
Comment 3 William Jon McCann 2013-10-24 15:16:07 UTC
Hmm, doesn't seem to apply here to master.
Comment 4 Florian Müllner 2013-10-24 15:21:57 UTC
Created attachment 258030 [details] [review]
ui: Display number of users in show-user-list button

Mmmh, no idea - this is a patch version from a separate branch with no additional patches, so should apply now ...
Comment 5 William Jon McCann 2013-10-24 15:34:12 UTC
Created attachment 258031 [details]
screenshot

Looks like a bit too much horizontal padding when the number is large. Also, the number in the headerbar is different from the number in the user list.
Comment 6 Florian Müllner 2014-02-25 18:58:58 UTC
Created attachment 270305 [details] [review]
ui: Display number of users in show-user-list button

(In reply to comment #5)
> Looks like a bit too much horizontal padding when the number is large.

Yeah, that's the standard padding for text buttons - this one uses custom padding and should do better.


> Also, the number in the headerbar is different from the number in the user list.

Yeah, should have been fixed in bug 710655 (and possibly others).
Comment 7 Florian Müllner 2014-02-25 19:08:15 UTC
(In reply to comment #6)
> (In reply to comment #5)
> > Looks like a bit too much horizontal padding when the number is large.
> 
> Yeah, that's the standard padding for text buttons - this one uses custom
> padding and should do better.

I also have an alternative patch which forces the button to be square (e.g. match the icon buttons), but it starts exceeding the desired height when numbers grow too large. We can work around that by render the number to an image and scale appropriately if we want that behavior ...
Comment 8 Florian Müllner 2014-02-27 17:44:51 UTC
Attachment 270305 [details] pushed as 017d635 - ui: Display number of users in show-user-list button

jimmac-approved, pushing
Comment 9 Florian Müllner 2014-02-27 17:48:40 UTC
Created attachment 270500 [details] [review]
ui: Display number of users in show-user-list button

Attaching the work-in-progress patch for the square button so that it doesn't get lost in case we want to revisit ...