After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 710655 - not seeing everyone in a room
not seeing everyone in a room
Status: RESOLVED FIXED
Product: polari
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Polari maintainers
Polari maintainers
Depends on:
Blocks:
 
 
Reported: 2013-10-22 14:49 UTC by William Jon McCann
Modified: 2013-10-28 22:26 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
screenshot (polari) (19.78 KB, image/png)
2013-10-22 14:49 UTC, William Jon McCann
  Details
screenshot (xchat) (37.44 KB, image/png)
2013-10-22 14:50 UTC, William Jon McCann
  Details
userList: Fix user count (2.98 KB, patch)
2013-10-28 22:25 UTC, Florian Müllner
committed Details | Review

Description William Jon McCann 2013-10-22 14:49:54 UTC
Created attachment 257851 [details]
screenshot (polari)

In Polari I'm seeing 23 people in a room where in XChat I see 75.
Comment 1 William Jon McCann 2013-10-22 14:50:17 UTC
Created attachment 257852 [details]
screenshot (xchat)
Comment 2 Florian Müllner 2013-10-28 22:25:40 UTC
Created attachment 258356 [details] [review]
userList: Fix user count

We currently set/update the user count according to the number of
rows in the list. As we shortcut setting/updating the header in
case it's unneeded, we can end up with a count that is less than
the actual number of users.
To fix, base the counter on the number of users rather than widgets,
and make sure to always update it on room member changes.
Comment 3 Florian Müllner 2013-10-28 22:26:14 UTC
Attachment 258356 [details] pushed as 902796f - userList: Fix user count