After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 710555 - no limitations in the height of the users list in login-screen
no limitations in the height of the users list in login-screen
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: login-screen
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Ray Strode [halfline]
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-10-20 17:19 UTC by sébastien lafargue
Modified: 2013-10-25 13:15 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
screenshot (98.54 KB, image/jpeg)
2013-10-20 17:20 UTC, sébastien lafargue 		  Details
theme: Add some vertical padding on login screen (807 bytes, patch)
2013-10-24 15:37 UTC, Florian Müllner 		accepted-commit_now Details | Review
theme: Add some vertical padding on login screen (848 bytes, patch)
2013-10-24 19:43 UTC, Florian Müllner 		committed Details | Review

Description sébastien lafargue 2013-10-20 17:19:51 UTC 
if you have a lot of users registered on your system, the users list in the login-screen can take the whole screen height and even overlap with panel and bottom logo

waiting for a design decision about what to do
Comment 1 sébastien lafargue 2013-10-20 17:20:25 UTC 
Created attachment 257769 [details]
screenshot
Comment 2 Matthias Clasen 2013-10-21 19:35:16 UTC 
Hmm, this has definitively been fixed at various points in the past.

Florian, did we regress ?
Comment 3 Florian Müllner 2013-10-24 15:37:35 UTC 
Created attachment 258032 [details] [review]
theme: Add some vertical padding on login screen

(In reply to comment #2)
> Hmm, this has definitively been fixed at various points in the past.
> 
> Florian, did we regress ?

Looks like it, yeah ...
(the underlying code has changed quite a bit this cycle)
Comment 4 Ray Strode [halfline] 2013-10-24 18:21:16 UTC 
Review of attachment 258032 [details] [review]:

++
Comment 5 sébastien lafargue 2013-10-24 19:20:15 UTC 
it's working for the top with the panel but not for the bottom with the logo
Comment 6 Florian Müllner 2013-10-24 19:43:12 UTC 
Created attachment 258050 [details] [review]
theme: Add some vertical padding on login screen

Indeed, fixed now.
Comment 7 Ray Strode [halfline] 2013-10-24 20:10:12 UTC 
Review of attachment 258050 [details] [review]:

++
Comment 8 Florian Müllner 2013-10-25 13:15:42 UTC 
Attachment 258050 [details] pushed as a16f699 - theme: Add some vertical padding on login screen