GNOME Bugzilla – Bug 710391
geometrictransform: rotate: fix angle property help text
Last modified: 2013-10-31 21:36:33 UTC
Created attachment 257537 [details] [review] rotate: fix angle property help text The help text of the angle property of the rotate plugin was probably copied from the circle plugin, the attached patch fixes it to mention the rotation determined by the angle. I fixed also the text in docs/plugins/gst-plugins-bad-plugins.args, but I don't know whether this file is supposed to be auto-generated form source or not. Thanks, Antonio
could you mention the direction of the rotation (clockwise or counter-clockwise)?
Hi Fabian, sure I could, but the documentation of the circle plugin does not specify the direction either and I don't want to diverge from that. BTW when nothing is specified the canonical circle must be assumed, and this is indeed the case: with angles in radians represented from P(0,1) and going counterclockwise. Maybe your remark can be addressed in a follow-up patch which improves the documentation for all the "angle like" properties ($ git grep g_param_spec | grep angle). Ciao, Antonio
commit fa12af3d0190cd2b6b7cbcc10977e981813106ad Author: Antonio Ospite <ospite@studenti.unina.it> Date: Thu Oct 17 12:05:44 2013 +0200 rotate: Fix angle property help text The help text of the angle property was probably copied from the circle plugin, fix it to mention the rotation determined by the angle. https://bugzilla.gnome.org/show_bug.cgi?id=710391