After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 710378 - Change order of ok and cancel buttons when renaming sheets
Change order of ok and cancel buttons when renaming sheets
Status: VERIFIED FIXED
Product: Gnumeric
Classification: Applications
Component: GUI
git master
Other Linux
: Normal normal
: ---
Assigned To: Jody Goldberg
Jody Goldberg
Depends on:
Blocks:
 
 
Reported: 2013-10-17 11:22 UTC by Xabier Rodríguez Calvar
Modified: 2013-10-19 10:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Reordering buttons in the rename dialog (2.22 KB, patch)
2013-10-17 16:10 UTC, Xabier Rodríguez Calvar 		none Details | Review
Reordering buttons in the resize dialog (1.58 KB, patch)
2013-10-17 16:18 UTC, Xabier Rodríguez Calvar 		none Details | Review

Description Xabier Rodríguez Calvar 2013-10-17 11:22:33 UTC 
If I am not mistaken, in GNOME Cancel button should be at the left and Ok at the right side in a dialog. I found this different order in Gnumeric a bit disturbing so I cooked this quick patch.

Please, let me know if it's ok to push it.
Comment 1 Morten Welinder 2013-10-17 13:28:34 UTC 
The patch didn't make into the bug system.  I note, that the resize
dialog looks the same, though.
Comment 2 Xabier Rodríguez Calvar 2013-10-17 16:10:47 UTC 
Created attachment 257555 [details] [review]
Reordering buttons in the rename dialog

(In reply to comment #1)
> The patch didn't make into the bug system.  I note, that the resize
> dialog looks the same, though.

Ready now.
Comment 3 Xabier Rodríguez Calvar 2013-10-17 16:12:06 UTC 
(In reply to comment #1)
> The patch didn't make into the bug system.  I note, that the resize
> dialog looks the same, though.

Um, I missed that, let me check and reupload the patch.
Comment 4 Xabier Rodríguez Calvar 2013-10-17 16:18:35 UTC 
Created attachment 257556 [details] [review]
Reordering buttons in the resize dialog

I though I didn't need to remake the patch but adding a new one for the resizing dialog.
Comment 5 Morten Welinder 2013-10-17 17:24:48 UTC 
This problem has been fixed in our software repository. The fix will go into the next software release. Thank you for your bug report.
Comment 6 Xabier Rodríguez Calvar 2013-10-19 10:22:59 UTC 
Thanks for pushing it!