After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 710363 - Adapt to changes in the redirect URI used by Facebook
Adapt to changes in the redirect URI used by Facebook
Status: RESOLVED FIXED
Product: gnome-online-accounts
Classification: Core
Component: general
3.8.x
Other All
: Normal normal
: ---
Assigned To: GNOME Online Accounts maintainer(s)
GNOME Online Accounts maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-10-17 08:29 UTC by Viktor
Modified: 2013-10-30 14:22 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Screenshot of the failed login (9.17 KB, image/png)
2013-10-17 08:29 UTC, Viktor
  Details
Output of gnome-control-center -v online-accounts whule reproducing the bug (104.43 KB, text/plain)
2013-10-17 08:30 UTC, Viktor
  Details
oauth2: Clean up (2.45 KB, patch)
2013-10-17 14:47 UTC, Debarshi Ray
committed Details | Review
oauth2: Adapt to changes in the redirect URL requested by Facebook (4.97 KB, patch)
2013-10-17 14:48 UTC, Debarshi Ray
none Details | Review
facebook: Update README (1.01 KB, patch)
2013-10-18 09:54 UTC, Debarshi Ray
committed Details | Review
oauth2: Clean up (8.91 KB, patch)
2013-10-18 11:43 UTC, Debarshi Ray
committed Details | Review
oauth2: Adapt to changes in the redirect URI used by Facebook (5.90 KB, patch)
2013-10-18 11:44 UTC, Debarshi Ray
committed Details | Review
[gnome-3-10] oauth2: Clean up (8.91 KB, patch)
2013-10-18 12:07 UTC, Debarshi Ray
committed Details | Review
[gnome-3-10] oauth2: Adapt to changes in the redirect URI used by Facebook (5.89 KB, patch)
2013-10-18 12:08 UTC, Debarshi Ray
committed Details | Review
[gnome-3-8] oauth2: Clean up (8.91 KB, patch)
2013-10-30 13:03 UTC, Debarshi Ray
committed Details | Review
[gnome-3-8] oauth2: Adapt to changes in the redirect URI used by Facebook (5.89 KB, patch)
2013-10-30 13:04 UTC, Debarshi Ray
none Details | Review
[gnome-3-8] oauth2: Adapt to changes in the redirect URI used by Facebook (5.89 KB, patch)
2013-10-30 14:20 UTC, Debarshi Ray
committed Details | Review

Description Viktor 2013-10-17 08:29:36 UTC
Created attachment 257482 [details]
Screenshot of the failed login

Adding a facebook account fails with the error message: "Authorisation response was: "(null)" as seen in attached screenshot. This is after logging in successfully, allowing Gnome to read my profile and allowing it to post. As I press "OK" on the last screen, the window closes down and the error message is displayed.

I've captured the output of gnome-control-center -v online-accounts and attached it to this bugreport.

OS: Fedora 20 Alpha 4
Package installed: gnome-online-accounts-3.10.0-2.fc20.x86_64

Steps to reproduce:
1. Open online accounts
2. Click add
3. Choose facebook
4. Login
5. Allow Gnome to access your public profile
6. Allow Gnome to post
...
Comment 1 Viktor 2013-10-17 08:30:49 UTC
Created attachment 257483 [details]
Output of gnome-control-center -v online-accounts whule reproducing the bug
Comment 2 Debarshi Ray 2013-10-17 09:48:56 UTC
I thought that I had messed up in bug 709570 but I just tested without those patches (Fedora 19 + gnome-online-accounts-3.8.3-3.fc19) and I get the same result.

It might be possible that something changed on the server-side.

Anyway, there is nothing that gnome-control-center can do. Reassigining to gnome-online-accounts.
Comment 3 Debarshi Ray 2013-10-17 14:47:58 UTC
Created attachment 257543 [details] [review]
oauth2: Clean up
Comment 4 Debarshi Ray 2013-10-17 14:48:39 UTC
Created attachment 257544 [details] [review]
oauth2: Adapt to changes in the redirect URL requested by Facebook
Comment 5 Jobo 2013-10-18 06:11:16 UTC
I just installed FC19 last night, ran all updates and encountered this same bug.
Comment 6 Debarshi Ray 2013-10-18 09:54:54 UTC
Created attachment 257628 [details] [review]
facebook: Update README

Another round of testing reminds me that Facebook uses the query to return error=access_denied, while the access_token is returned in the query. Ofcourse, you won't get error=access_denied if you had granted access to GNOME in the past.
Comment 7 Viktor 2013-10-18 11:37:43 UTC
Just chiming back into this bug to say that it's extremely pleasing to see such a fast response Debarshi! Thank you and keep up the good work!
Comment 8 Debarshi Ray 2013-10-18 11:43:29 UTC
Created attachment 257632 [details] [review]
oauth2: Clean up
Comment 9 Debarshi Ray 2013-10-18 11:44:00 UTC
Created attachment 257633 [details] [review]
oauth2: Adapt to changes in the redirect URI used by Facebook
Comment 10 Debarshi Ray 2013-10-18 12:07:35 UTC
Created attachment 257634 [details] [review]
[gnome-3-10] oauth2: Clean up
Comment 11 Debarshi Ray 2013-10-18 12:08:09 UTC
Created attachment 257635 [details] [review]
[gnome-3-10] oauth2: Adapt to changes in the redirect URI used by Facebook
Comment 12 Debarshi Ray 2013-10-18 12:09:01 UTC
I am reasonably confident about these that I am going to push them to master and gnome-3-10. I would like to backport them to gnome-3-8 as well, but I am going to wait a bit more before I do that.
Comment 13 Igor Gnatenko 2013-10-19 18:39:48 UTC
Close this bug, please
Comment 14 Debarshi Ray 2013-10-20 14:05:27 UTC
I will, once I am sure that the patches don't break anything and have backported it to gnome-3-8.
Comment 15 Debarshi Ray 2013-10-30 13:03:54 UTC
Created attachment 258566 [details] [review]
[gnome-3-8] oauth2: Clean up
Comment 16 Debarshi Ray 2013-10-30 13:04:53 UTC
Created attachment 258567 [details] [review]
[gnome-3-8] oauth2: Adapt to changes in the redirect URI used by Facebook
Comment 17 Debarshi Ray 2013-10-30 14:20:14 UTC
Created attachment 258575 [details] [review]
[gnome-3-8] oauth2: Adapt to changes in the redirect URI used by Facebook