After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 710235 - Custom game screen needs redesigned
Custom game screen needs redesigned
Status: RESOLVED FIXED
Product: gnome-mines
Classification: Applications
Component: general
git master
Other Linux
: Normal enhancement
: ---
Assigned To: gnome-mines-maint
gnome-mines-maint
Depends on:
Blocks:
 
 
Reported: 2013-10-16 02:07 UTC by Michael Catanzaro
Modified: 2014-04-17 13:16 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Custom game screen improvements (3.35 KB, patch)
2014-04-15 12:10 UTC, Robert Roth
committed Details | Review
Custom games: remove num mines spinner (6.54 KB, patch)
2014-04-17 13:16 UTC, Michael Catanzaro
committed Details | Review

Description Michael Catanzaro 2013-10-16 02:07:42 UTC
The custom game screen needs to be updated to match the new design.
Comment 1 Allan Day 2014-04-10 12:32:51 UTC
Latest mockups are here: https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/games/mines/mines2-new.png

It's just a minor change in layout and wording.
Comment 2 Robert Roth 2014-04-15 12:10:08 UTC
Created attachment 274357 [details] [review]
Custom game screen improvements

Improved custom game screen by:
* reworded fields based on mockup
* rearranged buttons
* added margin between the fields and the button area
* centered the whole custom game screen
* added suggested-action class to the play button
Comment 3 Michael Catanzaro 2014-04-15 19:15:47 UTC
Comment on attachment 274357 [details] [review]
Custom game screen improvements

This looks great, thank you!

I think we should additionally get rid of either the spinner to set the number of mines, or else the spinner to set the percentage of mines, since these fields are somewhat redundant with each other. Allan's mockup has the spinner for number of mines, but I think it'd be more intuitive to do percentage instead, since otherwise figuring out how dangerous your custom board size is would require unnecessary math.
Comment 4 Michael Catanzaro 2014-04-17 13:16:22 UTC
The following fix has been pushed:
b08d001 Custom games: remove num mines spinner
Comment 5 Michael Catanzaro 2014-04-17 13:16:24 UTC
Created attachment 274603 [details] [review]
Custom games: remove num mines spinner

We currently have a spinner to set the number of mines and a different
spinner to set the percentage of mines. These are redundant, and I like
the percentage spinner more, so remove the original one.