After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 710128 - Improve gst-rtsp-server address pool unit tests...
Improve gst-rtsp-server address pool unit tests...
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-rtsp-server
git master
Other All
: Normal enhancement
: 1.2.3
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-10-14 17:49 UTC by Sebastian Rasmussen
Modified: 2014-02-25 22:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch. (3.07 KB, patch)
2013-10-14 17:49 UTC, Sebastian Rasmussen 		committed Details | Review

Description Sebastian Rasmussen 2013-10-14 17:49:17 UTC 
Created attachment 257284 [details] [review]
Proposed patch.

These are the tests that I'm adding:

    Add a range with mixed IPV4 and IPV6 addresses to pool.
    Get an IPV4 address from an IPV6-only pool.
    Get an IPV6 address from an IPV4-only pool.
    Reserve a IPV6 address from an IPV4-only pool.
    Check for unicast addresses in multicast-only pool.
    Check for unicast addresses in uni-/multicast-mixed pool.

If you want them in separate commits I'm happy to provide that, but given that most are single-line tests it seems a bit unnecessary...
Comment 1 Sebastian Dröge (slomo) 2013-10-14 18:21:13 UTC 
commit cf82d90452a12637ee2fb6d5a99d1a9253721dcd
Author: Sebastian Rasmussen <sebras@hotmail.com>
Date:   Mon Oct 14 19:36:24 2013 +0200

    tests: Improve address pool unit tests
    
    Add a range with mixed IPV4 and IPV6 addresses to pool.
    Get an IPV4 address from an IPV6-only pool.
    Get an IPV6 address from an IPV4-only pool.
    Reserve a IPV6 address from an IPV4-only pool.
    Check for unicast addresses in multicast-only pool.
    Check for unicast addresses in uni-/multicast-mixed pool.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=710128