After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 709995 - Obsolete makefile rules
Obsolete makefile rules
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: build
unspecified
Other All
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2013-10-12 14:50 UTC by Ihar Hrachyshka
Modified: 2013-10-17 18:13 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fixed makefile syntax; [make test still fails due to other reasons] (1.26 KB, patch)
2013-10-12 14:50 UTC, Ihar Hrachyshka 		none Details | Review
Remove obsolete makefile rules (3.91 KB, patch)
2013-10-16 18:49 UTC, Ihar Hrachyshka 		accepted-commit_now Details | Review

Description Ihar Hrachyshka 2013-10-12 14:50:59 UTC 
Created attachment 257110 [details] [review]
Fixed makefile syntax; [make test still fails due to other reasons]

If I run 'make test' in my tree, I get the following:

parallels@ubuntu:~/hackaton/glib$ make test
make[1]: Entering directory `/home/parallels/hackaton/glib/m4macros'
make[1]: Leaving directory `/home/parallels/hackaton/glib/m4macros'
make[1]: Entering directory `/home/parallels/hackaton/glib/glib'
make[2]: Entering directory `/home/parallels/hackaton/glib/glib/libcharset'
make[2]: Leaving directory `/home/parallels/hackaton/glib/glib/libcharset'
make[2]: Entering directory `/home/parallels/hackaton/glib/glib/pcre'
make[2]: Leaving directory `/home/parallels/hackaton/glib/glib/pcre'
make[2]: Entering directory `/home/parallels/hackaton/glib/glib/update-pcre'
make[2]: Leaving directory `/home/parallels/hackaton/glib/glib/update-pcre'
make[2]: Entering directory `/home/parallels/hackaton/glib/glib/tests'
make[2]: *** No rule to make target `test'.  Stop.
make[2]: Leaving directory `/home/parallels/hackaton/glib/glib/tests'
/bin/bash: line 2: exit: test-nonrecursive: numeric argument required
make[1]: *** [test] Error 255
make[1]: Leaving directory `/home/parallels/hackaton/glib/glib'
/bin/bash: line 2: exit: test-nonrecursive: numeric argument required
make: *** [test] Error 255
Comment 1 Ihar Hrachyshka 2013-10-16 18:48:53 UTC 
It seems that this rule (and some other) are just obsolete, so there is no reason to fix them.
Comment 2 Ihar Hrachyshka 2013-10-16 18:49:16 UTC 
Created attachment 257442 [details] [review]
Remove obsolete makefile rules
Comment 3 Colin Walters 2013-10-17 17:19:44 UTC 
Review of attachment 257442 [details] [review]:

This looks correct to me.
Comment 5 Allison Karlitskaya (desrt) 2013-10-17 18:13:04 UTC 
These rules are only obsolete in-so-far as gtester itself should be considered obsolete.

If we want to deprecate gtester then maybe we should take a more thorough approach here -- gnome goal, etc.