After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 709858 - theoraenc: Do nothing when flushing the encoder when no caps were set
theoraenc: Do nothing when flushing the encoder when no caps were set
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
unspecified
Other All
: Normal normal
: 1.3.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-10-10 19:07 UTC by Thibault Saunier
Modified: 2013-10-14 21:18 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
theoraenc: Do nothing when flushing the encoder when no caps were set (1.12 KB, patch)
2013-10-10 19:07 UTC, Thibault Saunier 		committed Details | Review

Description Thibault Saunier 2013-10-10 19:07:53 UTC 
In case we receive a flush event before having our caps set, we will
end up trying to create a theora encoder even though we are not ready.
Avoid that situation making sure we are initialized before accepting to
be flushed.
Comment 1 Thibault Saunier 2013-10-10 19:07:57 UTC 
Created attachment 256944 [details] [review]
theoraenc: Do nothing when flushing the encoder when no caps were set
Comment 2 Thibault Saunier 2013-10-10 19:09:46 UTC 
Note that flushing when no caps were set is wrong behaviour, but shit happens, and we should avoid failling when it is the case I think.
Comment 3 Sebastian Dröge (slomo) 2013-10-14 20:28:58 UTC 
Why is flushing before caps are set wrong behaviour?
Comment 4 Thibault Saunier 2013-10-14 20:33:08 UTC 
Actually it is in that particular case, we flush right from the begining, it felt wrong to me. But indeed nothing should prevent us from being able to do it.
Comment 5 Thibault Saunier 2013-10-14 20:34:46 UTC 
Appart from that, is that patch OK for you?
Comment 6 Sebastian Dröge (slomo) 2013-10-14 20:42:44 UTC 
Yes
Comment 7 Thibault Saunier 2013-10-14 21:14:09 UTC 
Attachment 256944 [details] pushed as 508245d - theoraenc: Do nothing when flushing the encoder when no caps were set