After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 709762 - ClutterDragAction can mix pointer and touch events
ClutterDragAction can mix pointer and touch events
Status: RESOLVED FIXED
Product: clutter
Classification: Platform
Component: ClutterAction
1.16.x
Other Linux
: Normal normal
: ---
Assigned To: clutter-maint
clutter-maint
Depends on:
Blocks:
 
 
Reported: 2013-10-09 17:44 UTC by Lionel Landwerlin
Modified: 2013-10-14 16:45 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
drag-action: don't mix touch and pointer events (1.26 KB, patch)
2013-10-09 17:45 UTC, Lionel Landwerlin 		reviewed Details | Review
drag-action: don't mix touch and pointer events (1.79 KB, patch)
2013-10-14 16:07 UTC, Lionel Landwerlin 		committed Details | Review

Description Lionel Landwerlin 2013-10-09 17:44:34 UTC 
Just preventing pointer and touch events mixing in begin/capture.
Comment 1 Lionel Landwerlin 2013-10-09 17:45:05 UTC 
Created attachment 256846 [details] [review]
drag-action: don't mix touch and pointer events
Comment 2 Emmanuele Bassi (:ebassi) 2013-10-09 18:20:35 UTC 
Review of attachment 256846 [details] [review]:

this can only happen with pointer event emulated by touch devices, I guess. or mixing a drag with a touch screen with a pointer. care to elaborate a bit what kind of scenario would lead to mixing touch with pointer events? it would be great if you put it inside the commit message.
Comment 3 Lionel Landwerlin 2013-10-14 16:07:26 UTC 
Indeed, I get emulated pointer event as well as touch event, so the DragAction ends up processing the same event coordinates twice. These events are emitted from the same device.
I'm uploading a new patch that relaxes some of the tests since it's factorized at  the beginning of the function.
Comment 4 Lionel Landwerlin 2013-10-14 16:07:44 UTC 
Created attachment 257273 [details] [review]
drag-action: don't mix touch and pointer events
Comment 5 Emmanuele Bassi (:ebassi) 2013-10-14 16:24:16 UTC 
Review of attachment 257273 [details] [review]:

CR pass. please, commit to the clutter-1.16 branch.