After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 709687 - listbox: Fix keynav_failed() parameter in move_cursor()
listbox: Fix keynav_failed() parameter in move_cursor()
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2013-10-08 22:07 UTC by Florian Müllner
Modified: 2013-10-11 12:19 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
listbox: Fix keynav_failed() parameter in move_cursor() (1.65 KB, patch)
2013-10-08 22:07 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2013-10-08 22:07:34 UTC 
See patch.
Comment 1 Florian Müllner 2013-10-08 22:07:37 UTC 
Created attachment 256771 [details] [review]
listbox: Fix keynav_failed() parameter in move_cursor()

The 'direction' parameter to gtk_widget_keynav_failed() is based on
gtk_list_box_move_cursor()'s 'count' parameter. However if the passed
in movement is GTK_MOVEMENT_DISPLAY_LINES, 'count' is modified by
the keynav handling and will always be 0. To avoid messing up the
'direction' parameter, use a local variable for keynav handling and
leave 'count' untouched.
Comment 2 Alexander Larsson 2013-10-11 11:11:22 UTC 
Review of attachment 256771 [details] [review]:

ack
Comment 3 Florian Müllner 2013-10-11 12:19:27 UTC 
Attachment 256771 [details] pushed as dd85acb - listbox: Fix keynav_failed() parameter in move_cursor()

Ugh, git-bz failure ...