After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 709613 - GtkStack: Warn when setting a child visible which is not in the stack
GtkStack: Warn when setting a child visible which is not in the stack
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
3.9.x
Other Linux
: Normal enhancement
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2013-10-08 08:30 UTC by David King
Modified: 2013-10-09 11:14 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
warn when setting a child visible which is not in the stack (1.33 KB, patch)
2013-10-08 08:30 UTC, David King 		committed Details | Review

Description David King 2013-10-08 08:30:00 UTC 
GtkStack does not warn if setting a child to be visible when the child is not in the stack. It would be useful to warn, as otherwise it is quite difficult for the API user to know that they are doing something wrong.
Comment 1 David King 2013-10-08 08:30:59 UTC 
Created attachment 256693 [details] [review]
warn when setting a child visible which is not in the stack
Comment 2 Matthias Clasen 2013-10-08 22:13:19 UTC 
Review of attachment 256693 [details] [review]:

sure, looks fine. please also push it to the gtk-3-10 branch
Comment 3 David King 2013-10-09 11:14:43 UTC 
Comment on attachment 256693 [details] [review]
warn when setting a child visible which is not in the stack

Thanks, pushed to master and gtk-3-10 as 5f611831587507ff21e481a4afbbfc13a5441344 and 71affbeec0cca2cd6a01069dfd1c414a0079179b.