After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 709597 - No notification about required logout / reboot
No notification about required logout / reboot
Status: RESOLVED OBSOLETE
Product: gnome-tweak-tool
Classification: Applications
Component: general
3.10.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME Tweak Tool maintainer(s)
GNOME Tweak Tool maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-10-07 21:31 UTC by Dominique Leuenberger
Modified: 2017-05-29 23:32 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Dominique Leuenberger 2013-10-07 21:31:58 UTC 
gnome-tweak-tools is supposed to give a notification if it's necessary to restart the session.

Unfortunately, this seems not to happen.

Some steps to reproduce, that should trigger it:
* Start g-t-t
* Browse to Keyboard & Mouse
* Switch 'Show All input Sources" (on/off)

doing so, results in the followint stack trace on the console:

Traceback (most recent call last):

+ Trace 232585

  • File "/usr/lib/python2.7/site-packages/gtweak/widgets.py", line 178 in _on_changed_notify_logout 
    self.notify_logout()
  • File "/usr/lib/python2.7/site-packages/gtweak/tweakmodel.py", line 68 in notify_logout 
    self._logoutnotification = LogoutNotification()
  • File "/usr/lib/python2.7/site-packages/gtweak/utils.py", line 42 in getinstance 
    instances[cls] = cls()
  • File "/usr/lib/python2.7/site-packages/gtweak/utils.py", line 308 in __init__ 
    self._logout, None, None)
TypeError: add_action() takes exactly 5 arguments (6 given) 


(not sure where this code finds 6 arguments.. I only see 5 in the code).
Comment 1 Dominique Leuenberger 2013-10-07 21:34:34 UTC 
The 'offending' code is:

            self.notification.add_action(
                                "restart",
                                "Restart Session",
                                self._logout, None, None)

If I change that to
            self.notification.add_action(
                                "restart",
                                "Restart Session",
                                self._logout, None)

Then *I* can only see 4 arguments, but the code is happy and shows me notifications...
Comment 2 John Stowers 2013-10-07 21:39:37 UTC 
What is your distro?
Comment 3 Dominique Leuenberger 2013-10-07 21:41:19 UTC 
openSUSE 13.1; but I've seen an equal report in the Fedora bug tracker (https://bugzilla.redhat.com/show_bug.cgi?id=1010509), so I don't think that makes any difference.
Comment 4 John Stowers 2013-10-07 21:43:00 UTC 
except on ubuntu saucy, which I run, where it does not occur...
Comment 5 Dominique Leuenberger 2013-10-07 21:44:40 UTC 
(In reply to comment #4)
> except on ubuntu saucy, which I run, where it does not occur...

Hmm. 'THAT' is interesting :)

Maybe some 'versioning' can help:
 | Name                   | Type    | Version         | Arch   | Repository       
--+------------------------+---------+-----------------+--------+------------------
i | libnotify-tools        | package | 0.7.6-48.1      | x86_64 | GNOME:Factory    
i | libnotify4             | package | 0.7.6-48.1      | x86_64 | GNOME:Factory    
i | python-notify          | package | 0.1.1-44.1      | x86_64 | GNOME:Factory    
i | typelib-1_0-Notify-0_7 | package | 0.7.6-48.1      | x86_64 | GNOME:Factory
Comment 6 John Stowers 2013-10-07 21:46:52 UTC 
and your versions for gobject-introspection, or python-gi (or whatever the package is called there)?
Comment 7 Dominique Leuenberger 2013-10-08 07:54:25 UTC 
(In reply to comment #6)
> and your versions for gobject-introspection, or python-gi (or whatever the
> package is called there)?

Fully updated GNOME 3.10 stack; thus:
* gobject-introspection-1.38.0
* python-gobject-3.10.0
Comment 8 Dominique Leuenberger 2013-10-08 18:26:03 UTC 
Libnotify 0.7.6 seems to be the 'issue' with a different API.
gnome-music verifies at runtime what to do:
https://git.gnome.org/browse/gnome-music/commit/gnomemusic/notification.py?id=f204cd496ba460892b63d303e5fb2e2bfece4d7d

Apparently, ob ubuntu they reverted an upstream commit from libnotify; which might not be the smartest move in the long run (see https://bugs.launchpad.net/ubuntu/+source/libnotify/+bug/1223401 )
Comment 9 John Stowers 2013-10-08 19:55:32 UTC 
Amazing work tracking this down! Thanks so much.
Comment 10 Dominique Leuenberger 2014-03-07 23:30:42 UTC 
Interestinglly, nothing seems to have changed on gnome-tweak-tool but on GNOME 3.11.91 I no longer see the issue.

So unless you consider doing anything with this, I'd suggest to close this bug as well.
Comment 11 Jeremy Bicha 2017-05-29 23:32:47 UTC 
I'm closing this bug since you have reported that you can no longer reproduce the issues after installing updates.

Feel free to close your own bugs!