Created attachment 256614 [details] [review]
network: Fix run-time warning

The "edit" widget is only set as data when there is a connection
(in make_row) so only hide it when there is a connection.

Created attachment 256615 [details] [review]
network: Fix warnings when clicking Wi-Fi network

Those 2 widgets (the edit page, and the spinner) might be available
but we need to read about them from the correct widget, eg. the
GtkListBoxRow, not the GtkBox it contains.

Created attachment 256616 [details] [review]
network: Only start the spinner when we can stop it

Comment on attachment 256616 [details] [review]
network: Only start the spinner when we can stop it

The list box elements will be destroyed when the state changes, as refresh calls populate_ap_list, which empties and recreates the whole list.

Comment on attachment 256616 [details] [review]
network: Only start the spinner when we can stop it

Actually, for EAP networks, we'll just pop up a dialog, and cancelling it won't stop the spinner, so we still need that.

Review of attachment 256615 [details] [review]:

yes

Review of attachment 256614 [details] [review]:

Correct

Review of attachment 256616 [details] [review]:

Wouldn't it be better if connection_[add_]activate_cb() stopped the spinner when connection != NULL ?

Actually those two callbacks should be merged since the code is exactly the same modulo debug message which meh.

Attachment 256614 [details] pushed as ce8c2eb - network: Fix run-time warning
Attachment 256615 [details] pushed as 3c1b58a - network: Fix warnings when clicking Wi-Fi network

Created attachment 256634 [details] [review]
network: Merge two similar functions

Merge connection_add_activate_cb() and connection_activate_cb(),
the code is too similar.

Review of attachment 256634 [details] [review]:

Right.

But what about stopping the spinner here? Looks like the right place to me.

Review of attachment 256616 [details] [review]:

17:45 <@hadess> rtcm, we never get a signal back when connecting to an EAP network is cancelled
17:49 < rtcm> hadess: ah ok, I actually feared that would be the case :-/

So, ok

Comment on attachment 256616 [details] [review]
network: Only start the spinner when we can stop it

Attachment 256616 [details] pushed as 23bf28d - network: Only start the spinner when we can stop it

Attachment 256634 [details] pushed as 57b6436 - network: Merge two similar functions