GNOME Bugzilla – Bug 709480
Use autoreconf instead custom script
Last modified: 2015-04-03 18:04:19 UTC
Created attachment 256546 [details] [review] autogen.sh.in: Use autoreconf I guess this is the correct module to check instead patch every module separately. Tell me if Im wrong patch following
Yes, indeed, that's something I've been meaning to do as well, thanks.
Review of attachment 256546 [details] [review]: ::: autogen.sh.in @@ +74,3 @@ patch -p0 -R --forward < common/gettext.patch fi + tool_run "autopoint" "--force" "patch -p0 < common/gettext.patch" The problem here is that autoreconf will run autopoint again, making this patch go away. Best would probably be to find a solution to not require this patch at all
And now that this patch is gone, we can probably just get this bug fixed too. Tim, you want to do it? :)
Yes, will do.
Oops, been a while, sorry. Pushed to master now (fixing up the patch bit which has been removed): commit 95b0eed7636b0be4a2a5e631475c995ad9a5ddec Author: Javier Jardón <jjardon@gnome.org> Date: Sat Oct 5 18:07:00 2013 +0100 gst-autogen.sh: use autoreconf https://bugzilla.gnome.org/show_bug.cgi?id=709480 commit 2ebd00a0cb2dbee4db5fe006f54b3176ae82a4a6 Author: Tim-Philipp Müller <tim@centricular.com> Date: Fri Apr 3 13:08:02 2015 +0100 gst-autogen.sh: remove some unused helper funcs commit ad30ca9534600465bd5ee3c42f02a37f3554f8db Author: Tim-Philipp Müller <tim@centricular.com> Date: Wed Dec 25 23:48:57 2013 +0000 gst-autogen.sh: drop support for AUTORECONF env var autoreconf is hard-coded now after recent changes, so there's no point in checking for AUTORECONF if we're not going to use it anyway. It's not a standard environment variable anyway, nor should it be required for anything (autoreconf itself supports the environment variables AUTOM4TE, AUTOCONF, AUTOHEADER, AUTOMAKE, ACLOCAL, AUTOPOINT, LIBTOOLIZE, M4, and MAKE). https://bugzilla.gnome.org/show_bug.cgi?id=709480