After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 709444 - Expand tab width
Expand tab width
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks: 720749
 
 
Reported: 2013-10-04 18:29 UTC by William Jon McCann
Modified: 2013-12-20 17:23 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Center and expand tabs (2.86 KB, patch)
2013-10-04 18:29 UTC, William Jon McCann
none Details | Review
Center and expand tabs (4.56 KB, patch)
2013-10-04 18:45 UTC, William Jon McCann
needs-work Details | Review
Center and expand tabs (4.36 KB, patch)
2013-12-08 12:58 UTC, William Jon McCann
committed Details | Review

Description William Jon McCann 2013-10-04 18:29:17 UTC
I think it is much nicer to make tabs expand to use the entire available width.
This is consistent with our recommendations for other applications as well.
Comment 1 William Jon McCann 2013-10-04 18:29:52 UTC
Created attachment 256494 [details] [review]
Center and expand tabs
Comment 2 William Jon McCann 2013-10-04 18:45:08 UTC
Created attachment 256500 [details] [review]
Center and expand tabs
Comment 3 Reinout van Schouwen 2013-10-04 21:37:23 UTC
Will this retain the possibility to close multiple tabs in sequence by clicking their close buttons without moving the mouse pointer?
Comment 4 Yosef Or Boczko 2013-10-13 16:08:13 UTC
(In reply to comment #3)
> Will this retain the possibility to close multiple tabs in sequence by clicking
> their close buttons without moving the mouse pointer?

The patch not retain this, but I think isn't very important,
because have Ctrl+W for close a tabs in quickly.
Comment 5 Reinout van Schouwen 2013-10-13 19:53:52 UTC
(In reply to comment #4)

> The patch not retain this, but I think isn't very important,
> because have Ctrl+W for close a tabs in quickly.

Well, for what it's worth, the people at mozilla think it's important enough to let Firefox start resizing the tabs only after the mouse pointer leaves the tab area.
Comment 6 Yosef Or Boczko 2013-10-13 20:00:19 UTC
(In reply to comment #5)
> (In reply to comment #4)
> 
> > The patch not retain this, but I think isn't very important,
> > because have Ctrl+W for close a tabs in quickly.
> 
> Well, for what it's worth, the people at mozilla think it's important enough to
> let Firefox start resizing the tabs only after the mouse pointer leaves the tab
> area.

I not understand - have Firefox & Mozilla and have Web/Epiphany & GNOME.
The design of Web isn't must to be worth to Firefox.
Comment 7 Reinout van Schouwen 2013-10-13 20:12:04 UTC
I'd be the last one to advocate copying Firefox's UX just because. 
I'm talking about a specific interaction pattern here: closing a number of tabs in sequence by mouse clicks.
Having to chase the close button for each consecutive tab doesn't make it easier for the user.
Comment 8 Yosef Or Boczko 2013-10-13 20:28:06 UTC
(In reply to comment #7)
> I'd be the last one to advocate copying Firefox's UX just because. 
> I'm talking about a specific interaction pattern here: closing a number of tabs
> in sequence by mouse clicks.
> Having to chase the close button for each consecutive tab doesn't make it
> easier for the user.

I don't want to close a tabs by mouse clicks, isn't convenient and very slow,
compared to Ctrl+W. closed more than one tabs with by mouse click is not
relevant I think.
Comment 9 Reinout van Schouwen 2013-10-13 21:01:54 UTC
It may not be convenient or quick, but in my experience, _vast_ numbers of people use the mouse for everything just because they don't care to learn the keyboard shortcuts.
Comment 10 Claudio Saavedra 2013-10-15 12:08:31 UTC
I agree that what Reinout mentions would be nice to have. Not sure if it's nicely doable with GtkNotebook though.
Comment 11 Yosef Or Boczko 2013-10-20 15:54:44 UTC
Anyway, is the new design for the tabs:
https://wiki.gnome.org/GnomeOS/Design/Whiteboards/Tabs#Tentative_Design

It already land in gedit, so I think is right also to Web.
Comment 12 Yosef Or Boczko 2013-10-30 23:18:50 UTC
(In reply to comment #11)
> Anyway, is the new design for the tabs:
> https://wiki.gnome.org/GnomeOS/Design/Whiteboards/Tabs#Tentative_Design
> 
> It already land in gedit, so I think is right also to Web.

Also in nautilus now.
Comment 13 Claudio Saavedra 2013-12-08 12:26:53 UTC
Review of attachment 256500 [details] [review]:

I see this warning with the patch:

** (epiphany:11982): CRITICAL **: sync_load_status: assertion 'spinner != NULL && icon != NULL' failed

Other than that the patch is fine. You will probably need to update it now that there is no WebKit2 ifdefs in the code.
Comment 14 William Jon McCann 2013-12-08 12:58:02 UTC
Created attachment 263742 [details] [review]
Center and expand tabs
Comment 15 Claudio Saavedra 2013-12-08 14:16:59 UTC
Review of attachment 263742 [details] [review]:

lgtm
Comment 16 William Jon McCann 2013-12-08 14:52:03 UTC
Attachment 263742 [details] pushed as 605c730 - Center and expand tabs
Comment 17 Adolfo Jayme 2013-12-14 23:54:44 UTC
(In reply to comment #11)
What does that mean: “So a certain Gnome app just broke an important UX pattern, let’s consistenly break it in every app then!”

This is so important that Mozilla implemented it by following Chrome. Well, let’s file a bug against gtk+...