GNOME Bugzilla – Bug 709276
Percentage indicator for subcommands
Last modified: 2014-01-19 08:29:33 UTC
Commands like resize2fs can need a lot of time until they will finish. In this case it would be good if GParted would show besides the executed comamnd how far it is (if not already implemented in the newest version). For example resize2fs provides for this the option -p. Maybe some other commands are providing such an option too which could be used by GParted.
Thank you for your interest in improving GParted. Improved tracking of command progress by using asynchronous execution was introduced with Bug #685740 - Refactor to use asynchronous command execution. Further reporting of command progress was added with Bug #697662 - Do not hide the progress of the tools used. This request is a duplicate of Bug #467925 - gparted: add progress bar during operation. Please review bug #467925 and place future comments there. *** This bug has been marked as a duplicate of bug 467925 ***
Created attachment 256397 [details] [review] resize2fs text progress bars (v1) Hi Curtis, I realised that it wouldn't take much to correctly display the progress bars from resize2fs, so here's the patches. Enhance line discipline in PipeCapture::OnReadable() (#709276) Turn on resize2fs text progress bars (#709276) I wrote a test program, progressbars.py, which uses backspace and carriage return to display text progress bars in various ways. Run it from the command like first. Then temporarily renamed it to /sbin/fsck.hfsplus to test GParted with it. I also tested resizing ntfs and checking ext2 to confirm output / progress bars are displayed correctly for existing commands as well resize2fs. Thanks, Mike
Created attachment 256399 [details] Test program generating text progress bars in various ways
Thank you Mike for looking again at progress indication for resize2fs, and for developing a patch and providing a test program. I successfully tested this patch with ext2 and ntfs partitions for growing and checking. Also successfully tested with hfsplus and the test program from comment #3. In addition saved the details file from GParted 0.16.2 and compared the output to the same operation using this patch and all discrepancies could be easily accounted for (e.g., more or less time to execute a command). Hence I have committed the patch set from comment #2 to the git repository for inclusion in the next release of GParted. The relevant git commits can be viewed at the following links: Enhance line discipline in PipeCapture::OnReadable() (#709276) https://git.gnome.org/browse/gparted/commit/?id=1b54123580aa668d3a2c391cce2d60c65a1668f9 Turn on resize2fs text progress bar (#709276) https://git.gnome.org/browse/gparted/commit/?id=21e166c949bc89b55a6f427c820cd9f92edd3dfa
Removed the "duplicate" status of this report because an enhancement has been added to add a progress bar the details section for resize2fs.
This enhancement was included in the GParted 0.17.0 release on December 9, 2013.