After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 709275 - Lock screen notifications round label (badge) cropped at the bottom
Lock screen notifications round label (badge) cropped at the bottom
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: lock-screen
3.10.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
3.10.1 3.12
: 709671 710026 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2013-10-02 15:20 UTC by Ryan Lerch
Modified: 2014-02-17 12:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
screenshot (334.08 KB, image/jpeg)
2013-10-02 15:20 UTC, Ryan Lerch 		  Details
test script to generate two notifications (345 bytes, text/x-python)
2013-10-02 15:21 UTC, Ryan Lerch 		  Details
screenShield: Prevent cropped count badges (1.00 KB, patch)
2014-02-13 18:46 UTC, Carlos Soriano 		none Details | Review
messageTray: Add source actor without count label (4.80 KB, patch)
2014-02-14 17:43 UTC, Carlos Soriano 		committed Details | Review

Description Ryan Lerch 2013-10-02 15:20:32 UTC 
When multiple notifications from the same application occur, the notifications on the shield crop the counter at the bottom. (see the attached screenshot).

attached also is a quick script to generate a pair of notifications after a 5 second delay. (to allow you to lock the screen)
Comment 1 Ryan Lerch 2013-10-02 15:20:53 UTC 
Created attachment 256285 [details]
screenshot
Comment 2 Ryan Lerch 2013-10-02 15:21:45 UTC 
Created attachment 256286 [details]
test script to generate two notifications
Comment 3 Florian Müllner 2013-10-13 09:02:29 UTC 
*** Bug 710026 has been marked as a duplicate of this bug. ***
Comment 4 Allan Day 2013-10-18 13:27:43 UTC 
We already say "2 new notifications" in the notification; maybe it would be easiest to remove the badges for 3.10.x?
Comment 5 Florian Müllner 2013-10-19 12:44:07 UTC 
3.10.1? ;-)
Comment 6 Allan Day 2014-01-21 07:49:29 UTC 
*** Bug 709671 has been marked as a duplicate of this bug. ***
Comment 7 Carlos Soriano 2014-02-13 18:41:31 UTC 
Some padding solve it:
Before: http://imgur.com/ko8kcij
After: http://imgur.com/nIs0jlT
Comment 8 Carlos Soriano 2014-02-13 18:46:23 UTC 
Created attachment 269057 [details] [review]
screenShield: Prevent cropped count badges

Add some padding to the notification source box to prevent
cropped count labels. The padding added is the same value
as the displacement of the count badge.
To balance the increased padding, delete the spacing
between notifications.
Comment 9 Carlos Soriano 2014-02-14 17:43:47 UTC 
Created attachment 269130 [details] [review]
messageTray: Add source actor without count label

Split the current implementation of SourceActor into
SourceActor and SourceActorWithLabel.
In this manner we can use source actors withouth count labels,
required in the screenShield to not clash with the count
text label.
Comment 10 Carlos Soriano 2014-02-14 17:44:35 UTC 
(In reply to comment #9)
> Created an attachment (id=269130) [details] [review]
> messageTray: Add source actor without count label
> 
> Split the current implementation of SourceActor into
> SourceActor and SourceActorWithLabel.
> In this manner we can use source actors withouth count labels,
> required in the screenShield to not clash with the count
> text label.

As said in IRC we get rid of count labels in the screenshield to not clash with the count text label.
Comment 11 drago01 2014-02-17 12:02:24 UTC 
Review of attachment 269130 [details] [review]:

LG.
Comment 12 Carlos Soriano 2014-02-17 12:28:33 UTC 
Attachment 269130 [details] pushed as 598f750 - messageTray: Add source actor without count label