After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 709260 - Make Appdata translatable
Make Appdata translatable
Status: RESOLVED FIXED
Product: gnome-klotski
Classification: Applications
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: Michael Catanzaro
gnome-klotski-maint
Depends on:
Blocks:
 
 
Reported: 2013-10-02 12:48 UTC by Daniel Mustieles
Modified: 2013-10-05 19:13 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
AppData file translatable (2.24 KB, patch)
2013-10-02 12:48 UTC, Daniel Mustieles 		needs-work Details | Review
appdata: mark for translation (2.86 KB, patch)
2013-10-05 19:13 UTC, Michael Catanzaro 		committed Details | Review

Description Daniel Mustieles 2013-10-02 12:48:00 UTC 
Created attachment 256258 [details] [review]
AppData file translatable

Patch to make Appdata translatable
Comment 1 Michael Catanzaro 2013-10-05 16:16:09 UTC 
Review of attachment 256258 [details] [review]:

Same concerns here as in the Chess and Brasero patches:

* you need to rename the versioned .appdata.xml file to .appdata.xml.in
* the .appdata.xml.in file needs to be distributed (and the generated .appdata.xml should not be)
* POTFILES.in needs to list the .appdata.xml.in file (not the .appdata.xml)
* @INTLTOOL_XML_NOMERGE_RULE@ needs to be replaced with @INTLTOOL_XML_RULE@ so that the translations get merged into the installed .appdata.xml (otherwise you may be able to translate them, but the translations don't get used anywhere)

I'm concerned that there are similar patches submitted to a bunch of other modules, not only by you (I really do appreciate that you're trying to help!), which need to be fixed before maintainers who don't notice these things commit them.

Here's two sample commits:

1) Remove existing use of @INTLTOOL_XML_NOMERGE_RULE@ if present (obsolete way of translating gsettings): https://git.gnome.org/browse/iagno/commit/?id=365a0be08bc0f6257d01752c7567b8fbb48ea017
2) Mark the appdata for translation: https://git.gnome.org/browse/iagno/commit/?id=427f18cc73c9a7acd4fa0f3ae16edb645bbaf1e4
Comment 2 Michael Catanzaro 2013-10-05 16:37:42 UTC 
Actually it looks like nearly every module is distributing the generated .appdata.xml instead of the .appdata.xml.in.  That doesn't work. :/
Comment 3 Michael Catanzaro 2013-10-05 19:13:20 UTC 
Created attachment 256547 [details] [review]
appdata: mark for translation