After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 709237 - Add a GSettings wrapper class
Add a GSettings wrapper class
Status: RESOLVED WONTFIX
Product: gjs
Classification: Bindings
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gjs-maint
gjs-maint
: 709236 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2013-10-02 01:02 UTC by Mattias Bengtsson
Modified: 2013-10-02 02:21 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add a GSettings wrapper class (2.73 KB, patch)
2013-10-02 01:02 UTC, Mattias Bengtsson 		rejected Details | Review

Description Mattias Bengtsson 2013-10-02 01:02:49 UTC 
This adds a GSettings subclass that handles GVariant (un)boxing
automatically.

Should I redo this in a similar style to the stuff in modules/overrides 
instead?
Comment 1 Mattias Bengtsson 2013-10-02 01:02:51 UTC 
Created attachment 256226 [details] [review]
Add a GSettings wrapper class

The Settings class wraps a Gio.Settings object, but takes care of all
GVariant (un)boxing. This should make working with settings a much
less verbose experience.
Comment 2 Mattias Bengtsson 2013-10-02 01:03:43 UTC 
*** Bug 709236 has been marked as a duplicate of this bug. ***
Comment 3 Jasper St. Pierre (not reading bugmail) 2013-10-02 01:05:20 UTC 
Review of attachment 256226 [details] [review]:

No. You can keep this in gnome-maps if you really want it. I don't want this kind of crack in gjs.
Comment 4 Mattias Bengtsson 2013-10-02 01:22:02 UTC 
Review of attachment 256226 [details] [review]:

Wow. Thanks for the constructive feedback.
Comment 5 Mattias Bengtsson 2013-10-02 02:21:45 UTC 
Serious feedback would be appreciated.