After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 709126 - region screenshot doesn't work with shell menu down
region screenshot doesn't work with shell menu down
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-09-30 19:44 UTC by William Jon McCann
Modified: 2014-04-26 14:21 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
screenshot: Port to GrabHelper (4.26 KB, patch)
2014-04-25 23:06 UTC, Florian Müllner 		committed Details | Review

Description William Jon McCann 2013-09-30 19:44:09 UTC 
The region screenshot doesn't work with a shell menu down. If I drop the status menu and use shift printscreen to grab a region, the crosshair appears but doesn't let me define a region.
Comment 1 Florian Müllner 2014-04-25 23:06:06 UTC 
Created attachment 275178 [details] [review]
screenshot: Port to GrabHelper

Taking an area screenshot doesn't work currently when in "grab mode",
for instance when the message tray or top bar menus are open. Fix
this by using GrabHelper for selecting the area, so grabs are properly
stacked for us.
Comment 2 Jasper St. Pierre (not reading bugmail) 2014-04-25 23:10:05 UTC 
Review of attachment 275178 [details] [review]:

::: js/ui/screenshot.js
@@ +178,2 @@
         global.screen.set_cursor(Meta.Cursor.CROSSHAIR);
+        Main.uiGroup.set_child_above_sibling(this._group, null);

What is this for?
Comment 3 Florian Müllner 2014-04-26 07:14:57 UTC 
(In reply to comment #2)
> @@ +178,2 @@
>          global.screen.set_cursor(Meta.Cursor.CROSSHAIR);
> +        Main.uiGroup.set_child_above_sibling(this._group, null);
> 
> What is this for?

To make sure that the selection rect does not end up stacked below open top bar menus.
Comment 4 Jasper St. Pierre (not reading bugmail) 2014-04-26 14:04:30 UTC 
Review of attachment 275178 [details] [review]:

OK then.
Comment 5 Florian Müllner 2014-04-26 14:21:45 UTC 
Attachment 275178 [details] pushed as df08ae7 - screenshot: Port to GrabHelper