After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 708897 - Make Appdata file translatable
Make Appdata file translatable
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: General
unspecified
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks:
 
 
Reported: 2013-09-27 08:49 UTC by Daniel Mustieles
Modified: 2013-10-16 09:10 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Appdata translatable (3.81 KB, patch)
2013-09-27 08:49 UTC, Daniel Mustieles
none Details | Review
Patch updated (3.88 KB, patch)
2013-10-07 16:26 UTC, Daniel Mustieles
committed Details | Review

Description Daniel Mustieles 2013-09-27 08:49:41 UTC
Created attachment 255901 [details] [review]
Appdata translatable

Patch to make Appdata file translatable, to use it in GNOME Software
Comment 1 Daniel Mustieles 2013-10-07 16:26:39 UTC
Created attachment 256648 [details] [review]
Patch updated

Fixed some bugs in the previous patch.
Comment 2 Daniel Mustieles 2013-10-15 14:34:54 UTC
I've seen that empathy has been branched to gnome-3-10... it's ok to commit this patch into master branch?

Thanks!
Comment 3 Frederic Peters 2013-10-15 15:22:48 UTC
From a freeze point of view, it's also ok for 3.10, as it's translating strings that were not marked for translation.

On the other hand string freeze was on September 2nd and the untranslated/untranslatable appdata.xml file was commited on September 9th; and that's not nice at all, Empathy maintainers will be punished.
Comment 4 Daniel Mustieles 2013-10-15 15:26:55 UTC
(In reply to comment #3)
> From a freeze point of view, it's also ok for 3.10, as it's translating strings
> that were not marked for translation.
> 
> On the other hand string freeze was on September 2nd and the
> untranslated/untranslatable appdata.xml file was commited on September 9th; and
> that's not nice at all, Empathy maintainers will be punished.

Yes, that's why I would commit it into master branch, so it will be available for the next release
Comment 5 Frederic Peters 2013-10-15 15:37:56 UTC
Well, the strings are in English in released 3.10 tarballs. Short of reverting the appdata file, I'd also mark them for translations in 3.10, this gives a chance to have them translated later on (3.10.2).
Comment 6 Daniel Mustieles 2013-10-16 07:44:02 UTC
Should I notice about it in i18n-list before commiting or I can do it directly?
Comment 7 Frederic Peters 2013-10-16 08:17:43 UTC
Sure, it's always nice to notify them.
Comment 8 Daniel Mustieles 2013-10-16 09:09:47 UTC
Review of attachment 256648 [details] [review]:

Patch commited to both master and gnome-3-10 branches
Comment 9 Daniel Mustieles 2013-10-16 09:10:28 UTC
Thanks Frederic for your help!