After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 708887 - Can no longer drag items through the overview
Can no longer drag items through the overview
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: overview
3.10.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-09-27 05:24 UTC by Matthew Wardrop
Modified: 2013-10-11 18:17 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
overview: Ignore dragEnd while the animation is still in progress (973 bytes, patch)
2013-09-27 10:43 UTC, drago01
committed Details | Review
Revert "overview: Ignore dragEnd while the animation is still in progress" (825 bytes, patch)
2013-10-11 18:13 UTC, drago01
committed Details | Review
layout: Flush region update in showOverview (892 bytes, patch)
2013-10-11 18:13 UTC, drago01
committed Details | Review

Description Matthew Wardrop 2013-09-27 05:24:25 UTC
In GNOME 3.8 and earlier; it was possible to click and drag items (such as files) to the top left hand corner of the screen; which entered the Overview screen, and you can then hover over any app to focus it, and ultimately end the drag operation. This is very useful on small screens or when you prefer using maximised windows.

In the latest version (3.10.0.1); dragging the item to the top left hand corner still activates the overview; but when you attempt to drag down over an app, as soon as the mouse leaves the top bar; the overview quits. For obvious reasons, this makes it impossible to drag objects between windows in this manner.
Comment 1 drago01 2013-09-27 10:30:41 UTC
I can reproduce this but only if I move the mouse fast enough i.e if I "sit" in the corner until the animation finishes it works.
Comment 2 drago01 2013-09-27 10:43:58 UTC
Created attachment 255914 [details] [review]
overview: Ignore dragEnd while the animation is still in progress

Moving the mouse fast enough during xdnd will trigger a xdnd-leave event
because the input shape is not updated until after the animation is done.

So simply ignore the leave events while the animation is in progress.
Comment 3 Florian Müllner 2013-09-27 10:52:23 UTC
Review of attachment 255914 [details] [review]:

OK.
Comment 4 Matthew Wardrop 2013-09-27 10:54:02 UTC
Thanks :).
Comment 5 drago01 2013-09-27 10:54:52 UTC
Attachment 255914 [details] pushed as 80a3bb8 - overview: Ignore dragEnd while the animation is still in progress
Comment 6 drago01 2013-10-07 18:27:13 UTC
Seems like the bug still can be triggered with that patch applied.
Comment 7 Tobias Getzner 2013-10-10 15:57:28 UTC
It also feels like you need way too much pressure / acceleration to activate the overview when you are dragging something. Plus you have to hit the window corner spot on to tirgger overview mode. Afair you only had to drag something over the "Activities" label before.
Comment 8 drago01 2013-10-11 18:13:12 UTC
Created attachment 257041 [details] [review]
Revert "overview: Ignore dragEnd while the animation is still in progress"

This reverts commit 80a3bb85aa4a66ed55b3d7465500e1c1f7cade6c.

--

This patch was wrong.
Comment 9 drago01 2013-10-11 18:13:30 UTC
Created attachment 257042 [details] [review]
layout: Flush region update in showOverview

We cannot wait for the queued update region to fire when
xdnd is being used because a wrong input shape can result
into a xdnd leave event when the user moves the pointer fast.
Comment 10 Jasper St. Pierre (not reading bugmail) 2013-10-11 18:15:49 UTC
Review of attachment 257041 [details] [review]:

.
Comment 11 Jasper St. Pierre (not reading bugmail) 2013-10-11 18:16:00 UTC
Review of attachment 257042 [details] [review]:

OK.
Comment 12 drago01 2013-10-11 18:17:21 UTC
Attachment 257041 [details] pushed as 13e6a6d - Revert "overview: Ignore dragEnd while the animation is still in progress"
Attachment 257042 [details] pushed as f601086 - layout: Flush region update in showOverview