After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 708873 - Custom functions support
Custom functions support
Status: RESOLVED FIXED
Product: gnome-calculator
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gcalctool maintainers
gcalctool maintainers
Depends on:
Blocks:
 
 
Reported: 2013-09-26 20:59 UTC by Garima Joshi
Modified: 2013-11-09 21:32 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Code for implementing custom-functions support (80.31 KB, patch)
2013-09-26 21:04 UTC, Garima Joshi 		needs-work Details | Review
I am uploading the updated patch. All the conflicts are resolved and white-space errors are fixed. (81.34 KB, patch)
2013-10-18 08:16 UTC, Garima Joshi 		none Details | Review
All test-cases passed. (81.39 KB, patch)
2013-10-22 09:17 UTC, Garima Joshi 		committed Details | Review

Description Garima Joshi 2013-09-26 20:59:36 UTC 
Implementing support for user-defined functions which can be used the same way as built-in functions.
Comment 1 Garima Joshi 2013-09-26 21:04:41 UTC 
Created attachment 255882 [details] [review]
Code for implementing custom-functions support
Comment 2 PioneerAxon 2013-10-12 08:19:27 UTC 
Review of attachment 255882 [details] [review]:

Unfortunately the patch doesn't apply to the current state of master branch. Can you please rebase the patch and send it again?
Plus, there are few trailing white-spaces in at least 5 places in patch (lines 30, 168, 197, 206, 210). Can you fix them too?

Thank you. :)
Comment 3 Garima Joshi 2013-10-18 08:16:27 UTC 
Created attachment 257620 [details] [review]
I am uploading the updated patch. All the conflicts are resolved and white-space errors are fixed.
Comment 4 Garima Joshi 2013-10-22 09:17:12 UTC 
Created attachment 257823 [details] [review]
All test-cases passed.
Comment 5 PioneerAxon 2013-11-09 21:32:18 UTC 
Review of attachment 257823 [details] [review]:

Committed.

Thank you for your patch. :)