After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 708850 - DragAction warning when setting handle to null
DragAction warning when setting handle to null
Status: RESOLVED FIXED
Product: clutter
Classification: Platform
Component: ClutterAction
1.16.x
Other Linux
: Normal normal
: ---
Assigned To: clutter-maint
clutter-maint
Depends on:
Blocks:
 
 
Reported: 2013-09-26 15:51 UTC by Lionel Landwerlin
Modified: 2013-09-26 22:13 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
drag-action: fix warning when setting drag-handle to null (1.49 KB, patch)
2013-09-26 15:52 UTC, Lionel Landwerlin 		committed Details | Review

Description Lionel Landwerlin 2013-09-26 15:51:27 UTC 
There is a DragAction warning when setting the handle to null.
Comment 1 Lionel Landwerlin 2013-09-26 15:52:23 UTC 
Created attachment 255847 [details] [review]
drag-action: fix warning when setting drag-handle to null
Comment 2 Emmanuele Bassi (:ebassi) 2013-09-26 18:59:34 UTC 
Review of attachment 255847 [details] [review]:

looks good to me, with a minor comment.

feel free to commit after fixing it.

::: clutter/clutter-drag-action.c
@@ +1142,3 @@
   if (priv->drag_handle != NULL)
+    {
+      clutter_actor_transform_stage_point (handle, priv->press_x, priv->press_y,

I'd replace this `handle` with `priv->drag_angle` instead, to make it clear what we're using.
Comment 3 Lionel Landwerlin 2013-09-26 22:13:02 UTC 
Comment on attachment 255847 [details] [review]
drag-action: fix warning when setting drag-handle to null

Pushed to 1.16, this was already fixed on master.