After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 708781 - wayland: Keep track of button modifier state
wayland: Keep track of button modifier state
Status: RESOLVED FIXED
Product: clutter
Classification: Platform
Component: wayland
unspecified
Other All
: Normal normal
: ---
Assigned To: clutter-maint
clutter-maint
wayland
Depends on:
Blocks:
 
 
Reported: 2013-09-25 20:00 UTC by Jonas Ådahl
Modified: 2014-03-14 22:24 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
wayland: Keep track of button modifier state (2.41 KB, patch)
2013-09-25 20:00 UTC, Jonas Ådahl 		committed Details | Review

Description Jonas Ådahl 2013-09-25 20:00:08 UTC 
Keep track of the button modifier mask state in
ClutterInputDeviceWayland and push its state to new button events going
out.
Comment 1 Jonas Ådahl 2013-09-25 20:00:10 UTC 
Created attachment 255719 [details] [review]
wayland: Keep track of button modifier state

Keep track of the button modifier mask state in
ClutterInputDeviceWayland and push its state to new button events going
out.

Signed-off-by: Jonas Ådahl <jadahl@gmail.com>
Comment 2 Jonas Ådahl 2013-10-18 20:44:08 UTC 
Is this the correct way to submit patches?
Comment 3 Jonas Ådahl 2013-11-09 20:08:41 UTC 
Ping.
Comment 4 Emmanuele Bassi (:ebassi) 2013-12-06 14:24:30 UTC 
Review of attachment 255719 [details] [review]:

seems okay to me, but you probably want to ask Rob Bradford and the other people looking at Wayland for a full ACK.
Comment 5 Jonas Ådahl 2014-03-08 09:11:59 UTC 
Still no ACK after 5 months pending. The change itself, isn't it quite straight forward anyway?
Comment 6 Emmanuele Bassi (:ebassi) 2014-03-13 15:31:46 UTC 
the Wayland backend for Clutter was mostly maintained by Rob; I don't really test it during release, so I'm not the best person to vouch for patches there.

anyway, since Rob seems not to be involved in this work any more, I'll just ACK it.
Comment 7 Emmanuele Bassi (:ebassi) 2014-03-13 15:32:27 UTC 
Review of attachment 255719 [details] [review]:

let's get it in.
Comment 8 Jonas Ådahl 2014-03-13 16:01:53 UTC 
Thanks. FYI, I don't have commit access.
Comment 9 Matthias Clasen 2014-03-14 22:24:22 UTC 
Attachment 255719 [details] pushed as a4440b7 - wayland: Keep track of button modifier state