After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 708629 - codecparsers: Fix the quantization matrix scan order for h264
codecparsers: Fix the quantization matrix scan order for h264
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal enhancement
: 1.3.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks: 706406
 
 
Reported: 2013-09-23 14:42 UTC by sreerenj
Modified: 2013-12-09 10:43 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
codecparsers: h264: store quantization matrices in zig-zag order (1.54 KB, patch)
2013-09-23 14:42 UTC, sreerenj 		committed Details | Review
codecparsers: h264: add helpers to convert quantization matrices (4.50 KB, patch)
2013-09-23 14:43 UTC, sreerenj 		needs-work Details | Review
codecparsers: h264: add helpers to convert quantization matrices. (5.16 KB, patch)
2013-10-02 08:28 UTC, sreerenj 		committed Details | Review
Ad a new libgstcodecparsers.def file to win32/common/ (2.34 KB, patch)
2013-10-02 08:42 UTC, sreerenj 		committed Details | Review

Description sreerenj 2013-09-23 14:42:42 UTC 
Created attachment 255572 [details] [review]
codecparsers: h264: store quantization matrices in zig-zag order

This has cloned from https://bugzilla.gnome.org/show_bug.cgi?id=706406. 
Patches are also the same but initially build against https://gitorious.org/vaapi/gstreamer-codecparsers/source/a2c653f958bbd464b0c97becf97be77f1ba47595: .

Anyway i am attaching the same patches here for gst-plugins-bad.
Comment 1 sreerenj 2013-09-23 14:43:13 UTC 
Created attachment 255573 [details] [review]
codecparsers: h264: add helpers to convert quantization matrices
Comment 2 Sebastian Dröge (slomo) 2013-10-01 21:33:14 UTC 
Review of attachment 255573 [details] [review]:

Please add it to the docs and win32/common/*.def

::: gst-libs/gst/codecparsers/gsth264parser.c
@@ +2011,3 @@
+ * @out_quant arguments.
+ *
+ * Since: 1.2

Since: 1.4
Comment 3 sreerenj 2013-10-02 08:28:16 UTC 
Created attachment 256236 [details] [review]
codecparsers: h264: add helpers to convert quantization matrices.
Comment 4 sreerenj 2013-10-02 08:42:39 UTC 
Created attachment 256239 [details] [review]
Ad a new libgstcodecparsers.def file to win32/common/
Comment 5 Sebastian Dröge (slomo) 2013-10-02 09:03:02 UTC 
commit e943f56bf8c8ef14bcac8e98510f323acf96475a
Author: Sreerenj Balachandran <sreerenj.balachandran@intel.com>
Date:   Tue Aug 20 17:03:38 2013 +0300

    codecparsers: h264: store quantization matrices in zig-zag order
    
    Quantizer matrices are encoded in zigzag scan order in the bitstream,
    so always parse it as it is.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=708629

commit 7622c9b10aef79a378d24ae38872333a56109eec
Author: Sreerenj Balachandran <sreerenj.balachandran@intel.com>
Date:   Wed Oct 2 11:40:05 2013 +0300

    win32: update with the new file libgstcodecparsers.def
    
    https://bugzilla.gnome.org/show_bug.cgi?id=708629

commit 8c9eaf0dc900f859d59d01da9c5d8bcdc89bb27c
Author: Sreerenj Balachandran <sreerenj.balachandran@intel.com>
Date:   Wed Oct 2 11:24:58 2013 +0300

    codecparsers: h264: add helpers to convert quantization matrices
    
    Add utility functions to convert quantization matrices from zig-zag scan
    order into raster scan order and vice-versa
    
    https://bugzilla.gnome.org/show_bug.cgi?id=708629