After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 708605 - testclock: Does not handle unscheduled entries correctly
testclock: Does not handle unscheduled entries correctly
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal blocker
: 1.2.0
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-09-23 09:48 UTC by Wim Taymans
Modified: 2013-09-23 10:16 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch to fix the issue (3.18 KB, patch)
2013-09-23 09:49 UTC, Wim Taymans 		committed Details | Review

Description Wim Taymans 2013-09-23 09:48:08 UTC 
A clock should return GST_CLOCK_UNSCHEDULED when an unscheduled entry is used for _wait() or _wait_async(). The testclock does not do this and this causes occasional timeouts in some unit tests.
Comment 1 Wim Taymans 2013-09-23 09:49:11 UTC 
Created attachment 255553 [details] [review]
patch to fix the issue

Attached patch fixes the issue and adds a unit test.
Comment 2 Wim Taymans 2013-09-23 10:13:37 UTC 
commit cba26c9ed901e9cce4812519db5f04ac0d198f5d
Author: Wim Taymans <wim.taymans@collabora.co.uk>
Date:   Mon Sep 23 11:47:14 2013 +0200

    tests: handle unscheduled entries correctly
    
    Make the testclock return GST_CLOCK_UNSCHEDULED when an unscheduled entry is
    used for gst_clock_wait() or gst_clock_wait_async().
    
    Fixes https://bugzilla.gnome.org/show_bug.cgi?id=708605