After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 708505 - matroskademux: sends unnecessary gap events
matroskademux: sends unnecessary gap events
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other All
: Normal normal
: 1.2.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-09-20 23:02 UTC by Matej Knopp
Modified: 2013-09-30 08:25 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to update stream position when sending buffers (1.11 KB, patch)
2013-09-20 23:02 UTC, Matej Knopp 		needs-work Details | Review

Description Matej Knopp 2013-09-20 23:02:22 UTC 
Created attachment 255451 [details] [review]
Patch to update stream position when sending buffers

that actually overlap with buffers. the problem is that stream->pos is never updated when sending buffers to the code that sends gap events doesn't know which time has already been covered.
Comment 1 Thiago Sousa Santos 2013-09-24 22:28:59 UTC 
So I did a minor update to your patch to avoid double checking if the same value as a valid clock time and pushed. In my tests it reduced the amount of gap events sent a lot. Thanks!

commit a1a493dae4f7e0cdbbb9a04c40db757898831b57
Author: Matej Knopp <matej.knopp@gmail.com>
Date:   Sat Sep 21 00:55:26 2013 +0200

    matroskademux: update stream->pos when sending buffers so that gap events are not sent unnecessarily
    
    https://bugzilla.gnome.org/show_bug.cgi?id=708505
Comment 2 Thiago Sousa Santos 2013-09-24 22:29:36 UTC 
Comment on attachment 255451 [details] [review]
Patch to update stream position when sending buffers

Pushed with a minor difference, so marking this version as obsolete