After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 708330 - Labels aren't vertically centered against icons
Labels aren't vertically centered against icons
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: system-status
3.9.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-09-18 21:13 UTC by Allan Day
Modified: 2013-09-19 16:42 UTC
See Also:
GNOME target: ---
GNOME version: 3.9/3.10


Attachments
screenshot (518.95 KB, image/png)
2013-09-18 21:13 UTC, Allan Day
  Details
popupMenu: Center the labels in submenu items (1.44 KB, patch)
2013-09-18 21:38 UTC, Jasper St. Pierre (not reading bugmail)
committed Details | Review

Description Allan Day 2013-09-18 21:13:42 UTC
Created attachment 255256 [details]
screenshot

At first I thought that this was because St doesn't have baseline alignment. Then I noticed that labels without descenders also have vertical alignment issues.

You can see in the attached screenshot that "Andreas Nilsson" is too high (2px too high, to be exact). Misalignment is also clear for the "Wi-Fi" label.
Comment 1 Jasper St. Pierre (not reading bugmail) 2013-09-18 21:38:55 UTC
Created attachment 255258 [details] [review]
popupMenu: Center the labels in submenu items
Comment 2 Florian Müllner 2013-09-18 21:42:01 UTC
Review of attachment 255258 [details] [review]:

OK.
Comment 3 Jasper St. Pierre (not reading bugmail) 2013-09-18 22:46:35 UTC
Screenshot: http://i.imgur.com/uHQLBgj.png
Comment 4 Jasper St. Pierre (not reading bugmail) 2013-09-19 16:42:04 UTC
Attachment 255258 [details] pushed as 33a4f59 - popupMenu: Center the labels in submenu items