After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 708283 - universal-access: Remove the mnemonic-activate handler
universal-access: Remove the mnemonic-activate handler
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Universal Access
unspecified
Other All
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-09-18 12:24 UTC by Rui Matos
Modified: 2013-10-01 08:04 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
universal-access: Remove the mnemonic-activate handler (3.92 KB, patch)
2013-09-18 12:24 UTC, Rui Matos 		committed Details | Review

Description Rui Matos 2013-09-18 12:24:54 UTC 
See patch.
Comment 1 Rui Matos 2013-09-18 12:24:56 UTC 
Created attachment 255174 [details] [review]
universal-access: Remove the mnemonic-activate handler

It's wrong because the label's parent isn't a GtkListBoxRow which
causes a warning.

In any case, we don't need it since GtkLabel already does the work of
finding a suitable parent widget to activate on mnemonic-activate
which ends up causing GtkListBox to fire its row-activated signal that
we already handle.
Comment 2 Matthias Clasen 2013-09-18 19:43:32 UTC 
Review of attachment 255174 [details] [review]:

looks good. This is leftovers from when we were using EggListBox, I'd say.
Comment 3 Bastien Nocera 2013-10-01 08:04:48 UTC 
Attachment 255174 [details] pushed as 7a27143 - universal-access: Remove the mnemonic-activate handler