After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 708265 - add support for GNU/Hurd in GLib D-Bus Library
add support for GNU/Hurd in GLib D-Bus Library
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: general
2.37.x
Other GNU Hurd
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2013-09-17 21:30 UTC by Svante Signell
Modified: 2013-10-04 13:57 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
hurd support in gio/{,tests}/gcredentials.c (6.18 KB, patch)
2013-09-17 21:30 UTC, Svante Signell 		rejected Details | Review

Description Svante Signell 2013-09-17 21:30:38 UTC 
Created attachment 255138 [details] [review]
hurd support in gio/{,tests}/gcredentials.c

Hi,

The attached patch solves the functionality problems for GNU/Hurd adding __GNU_ to selected parts of the code. The places are the same as for kFreeBSD_, they both have SCMCREDS defined, in contrast to Linux.
Comment 1 Allison Karlitskaya (desrt) 2013-09-18 01:58:15 UTC 
Review of attachment 255138 [details] [review]:

This looks reasonably straight forward.  I confirmed that __GNU__ is not defined here with GCC-on-Linux (which defines only __GNUC__).

We're in a hard freeze right now, so please wait until after the release to commit this.
Comment 2 Matthias Clasen 2013-09-18 10:13:08 UTC 
I have to say I hate the proliferation of semirandom platform checks in some parts of the gio code. Three in one place seems to be about the right time to add a feature check in configure ?
Comment 3 Dan Winship 2013-09-18 13:38:18 UTC 
bug 701482 has a good plan for simplifying the GCredentials platform checks. I'll try to deal with that soon if no one else does.
Comment 4 Dan Winship 2013-09-19 20:44:36 UTC 
Comment on attachment 255138 [details] [review]
hurd support in gio/{,tests}/gcredentials.c

wip/danw/creds now has a cleanup, followed by a much simplified (ie, one-line) version of this patch
Comment 5 Dan Winship 2013-10-04 13:57:54 UTC 
Fixed in master, will probably end up in glib-2-38