GNOME Bugzilla – Bug 708231
Provide an AppData file to integrate with GNOME Software Center
Last modified: 2013-11-05 08:44:43 UTC
It seems we would need to do this if we want frogr to show up in GSC in Fedora 21: http://blogs.gnome.org/hughsie/2013/09/13/my-application-isnt-showing-in-the-gnome-software-center/
It seems there's even a validation tool now for this: http://blogs.gnome.org/hughsie/2013/09/18/appdata-validation-tool/
Created attachment 255260 [details] [review] Add an AppData description for Frogrs Add data/frogr.appdata.xml file See http://people.freedesktop.org/~hughsient/appdata/ for more details.
Thanks, Mario for this tool. I will check the patch with them.
Review of attachment 255260 [details] [review]: Wow! That was fast! Thanks a lot for contributing this file, Ana. It's already looking great with the exception of a mistake in the id and a couple of minor nitpicks. I hope you can forgive me for those! :) Also, by looking at the "real world example" in http://people.freedesktop.org/~hughsient/appdata/example.patch, I think there are still some missing bits in the Makefile.am file. Just a couple of lines to install the appData file in the right place, I think. ::: data/frogr.appdata.xml @@ +1,3 @@ +<?xml version="1.0" encoding="UTF-8"?> +<application> + <id type="desktop">frogr.desktop.in.in</id> I think you want to put just "frogr.desktop" here, as the .in.in file is an input file that will be used to generate the one that will be finally installed in the system. @@ +8,3 @@ + <p>Frogr: a Flickr Remote Organizer for GNOME</p> + <p> + Frogr is a small application for the GNOME desktop that allows users to manage their accounts in the Flickr image hosting website. This line seems to long. What about cutting it down to something like 70-80 characters per line max? I guess something like this would perhaps look better: <p> Frogr is a small application for the GNOME desktop that allows users to manage their accounts in the Flickr image hosting website. </p> @@ +10,3 @@ + Frogr is a small application for the GNOME desktop that allows users to manage their accounts in the Flickr image hosting website. + </p> + <p> It supports all the basic Flickr features, including uploading pictures, adding descriptions, setting tags and managing sets and groups pools. There's a extra space at the beginning that is not needed, and perhaps I would also go here for a multi-line layout, following a scheme similar to the proposed above: <p> It supports all the basic Flickr features, including uploading pictures, adding descriptions, setting tags and managing sets and groups pools. </p> @@ +16,3 @@ + <screenshot type="default" width="377" height="236">https://wiki.gnome.org/Apps/Frogr?action=AttachFile&do=get&target=frogr-0_8-screenshot-thumb.png</screenshot> + </screenshots> + <url type="homepage">https://wiki.gnome.org/Apps/Frogr</url> I would probably use just http:// instead of https:// for consistency with the rest of the app (which you also worked on btw, thanks!), and because there's a redirection in place anyway, so it will just work in any case.
Created attachment 255400 [details] [review] Add an AppData description for Frogrs Add data/frogr.appdata.xml file See http://people.freedesktop.org/~hughsient/appdata/ for more details.
(In reply to comment #4) > Review of attachment 255260 [details] [review]: > > Wow! That was fast! > > Thanks a lot for contributing this file, Ana. It's already looking great with > the exception of a mistake in the id and a couple of minor nitpicks. I hope you > can forgive me for those! :) > > Also, by looking at the "real world example" in > http://people.freedesktop.org/~hughsient/appdata/example.patch, I think there > are still some missing bits in the Makefile.am file. Just a couple of lines to > install the appData file in the right place, I think. > > ::: data/frogr.appdata.xml > @@ +1,3 @@ > +<?xml version="1.0" encoding="UTF-8"?> > +<application> > + <id type="desktop">frogr.desktop.in.in</id> > > I think you want to put just "frogr.desktop" here, as the .in.in file is an > input file that will be used to generate the one that will be finally installed > in the system. I didn't understand why this file has this name. Thank for the explanation:) > > @@ +8,3 @@ > + <p>Frogr: a Flickr Remote Organizer for GNOME</p> > + <p> > + Frogr is a small application for the GNOME desktop that allows users to > manage their accounts in the Flickr image hosting website. > > This line seems to long. What about cutting it down to something like 70-80 > characters per line max? > > I guess something like this would perhaps look better: > <p> > Frogr is a small application for the GNOME desktop that allows users > to manage their accounts in the Flickr image hosting website. > </p> > > @@ +10,3 @@ > + Frogr is a small application for the GNOME desktop that allows users to > manage their accounts in the Flickr image hosting website. > + </p> > + <p> It supports all the basic Flickr features, including uploading pictures, > adding descriptions, setting tags and managing sets and groups pools. > > There's a extra space at the beginning that is not needed, and perhaps I would > also go here for a multi-line layout, following a scheme similar to the > proposed above: > > <p> > It supports all the basic Flickr features, including uploading > pictures, adding descriptions, setting tags and managing sets and > groups pools. > </p> > > @@ +16,3 @@ > + <screenshot type="default" width="377" > height="236">https://wiki.gnome.org/Apps/Frogr?action=AttachFile&do=get&target=frogr-0_8-screenshot-thumb.png</screenshot> > + </screenshots> > + <url type="homepage">https://wiki.gnome.org/Apps/Frogr</url> > > I would probably use just http:// instead of https:// for consistency with the > rest of the app (which you also worked on btw, thanks!), and because there's a > redirection in place anyway, so it will just work in any case. I changed all you told me and I've uploaded a new patch.
Committed. Thanks! https://git.gnome.org/browse/frogr/commit/?id=46842b683395724f9378f0546b91cea864080c02
Created attachment 258938 [details] [review] Make Appdata file translatable Note that Appdata file must be translatable. This patch does it ;-)
Reopening, to make Appdata file translatable
Comment on attachment 258938 [details] [review] Make Appdata file translatable (In reply to comment #8) > Created an attachment (id=258938) [details] [review] > Make Appdata file translatable > > Note that Appdata file must be translatable. > This patch does it ;-) Thanks a lot for providing this patch
Review of attachment 258938 [details] [review]: Commited: https://git.gnome.org/browse/frogr/commit/?id=a563120713cf4c94bca83a3596751a58c4f797e4 Thanks!