Created attachment 255082 [details] [review]
datetime: Use the currently preferred way for setting accessible names

For entries that have labels associated, use the mnemonic relationship; and for
those that don't, set up the accessible name.

Review of attachment 255082 [details] [review]:

ok

Created attachment 255105 [details] [review]
datetime: Use the currently preferred way for setting accessible names

For entries that have labels associated, use the mnemonic relationship; and for
those that don't, set up the accessible name.

Created attachment 255106 [details] [review]
datetime: Sync AM/PM button's accessible name with the text displayed

Instead of hardcoding the accessible name as "Switch between AM and
PM.", set it to "AM" or "PM" depending on which label the stack switcher
is currently showing.

Review of attachment 255105 [details] [review]:

This makes good sense to me. Thanks for doing it! (not my place to accept-commit-now it)

Review of attachment 255106 [details] [review]:

I've not tried this yet, but we discussed this approach in IRC as a means to notify Orca that the name has changed. Given that you tried it with Orca and that Orca is presenting the changed name when it changes and the correct name when you give it focus, I'm all in favor of it. :)

Thanks!

Review of attachment 255105 [details] [review]:

ok

Review of attachment 255106 [details] [review]:

Not tested but seems right

Attachment 255105 [details] pushed as 538032d - datetime: Use the currently preferred way for setting accessible names
Attachment 255106 [details] pushed as 17a8595 - datetime: Sync AM/PM button's accessible name with the text displayed