After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 70798 - Accessibility patch for pager.
Accessibility patch for pager.
Status: RESOLVED FIXED
Product: libwnck
Classification: Core
Component: general
0.x
Other Solaris
: High minor
: ---
Assigned To: libwnck maintainers
libwnck maintainers
Depends on:
Blocks:
 
 
Reported: 2002-02-07 10:56 UTC by padraig.obriain
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Provides accessiblity support to libwnck's components used by pager applet and also adds accessibility features to pager applet. (60.00 KB, application/octet-stream)
2002-03-21 20:45 UTC, Rajkumar
  Details
Patch for the above stated bug, to set a default-button for the property box. (1.64 KB, patch)
2002-03-25 17:26 UTC, Rajkumar
none Details | Review
updated patch as mentioned above (70.00 KB, application/octet-stream)
2002-03-31 00:22 UTC, Rajkumar
  Details
Patch for changes in libwnck/* (5.27 KB, patch)
2002-05-21 10:44 UTC, Rajkumar
none Details | Review
Patch for new files in libwnck/* (36.27 KB, patch)
2002-05-21 10:45 UTC, Rajkumar
none Details | Review
patch for changes in gnome-panel/applets/gen_util/* (5.19 KB, patch)
2002-05-21 10:47 UTC, Rajkumar
none Details | Review
README File (1.35 KB, text/plain)
2002-05-21 10:54 UTC, Rajkumar
  Details

Description padraig.obriain 2002-02-07 10:56:41 UTC
The widget WnckPager cannot be manipulated using the keyboard so cannot be
used to switch between workspaces using the keyboard.

One must use window manager short cuts to do it.
Comment 1 Havoc Pennington 2002-02-07 15:13:21 UTC
Does it matter that the keyboard shortcuts for the pager are
implemented in the WM process? It's all the same to users.
Comment 2 padraig.obriain 2002-02-08 08:41:20 UTC
The problem is that the WnckPager widget provides functionality to
non-disabled users but this functionality is not available to disabled
users.

Apart from the non-ability to manipulate the widget from the keyboard,
the information which this widget gives to a sighted user is not
available to a non-sighted user.

Comment 3 Havoc Pennington 2002-02-08 16:05:38 UTC
OK, what I'm saying is that the pager is essentially a mini-view of 
windows onscreen, and a shortcut for moving said windows around. 
i.e. it is a device that proxies for the window manager.

My point would be that it's a very visual-centric device for doing
that. Its whole purpose is that it's a mini _display_ of the windows
onscreen.

I would expect that a blind user wants some other kind of device for 
the same purpose, such as an audio summary of the windows. And there
is no reason they want the audio summary to be an audio summary of a
mini view of the windows, vs an audio summary of the actual windows.
i.e. what is the point of getting the pager involved; just have a
"screen reader pager". The visual pager would be a really stupid
intermediary.

i.e. I want to hear the screen reader say, "new workspace, windows are
"x" "y" "z"" I don't want to have to first tab to the pager then 
have the pager say "mini workspace, has mini icons for windows "x" "y"
"z"".

Or if using voice control, I want to say "focus window "x"", I don't
want to say "focus panel, tab, tab, tab, tab, focus mini-window "x""
Or equivalently I want to just say "workspace 2" and have it switch, I
don't want to tab to the pager first.
The whole point of libwnck is to export the info from the window
manager, giving us multiple ways of interacting with the window
manager. So writing a window manager access module that is
functionally equivalent to the pager should be simple.

I simply don't see what functionality the pager provides that is 
in addition to the WM functionality; its functionality is entirely 
redundant with WM functionality, it is simply presented in a "mini" or
smaller-screen-area format. The size of the information makes no
difference at all to a blind user, so the pager has _zero_
functionality for them, right? It's just a useless repeat of the 
same thing the WM does.
Comment 4 Luis Villa 2002-03-01 20:11:54 UTC
Have to agree with Havoc on this one; it would seem people working on
keynav probably have better things to spend their time on.
Comment 5 Havoc Pennington 2002-03-01 20:32:08 UTC
I'm even going to NOTABUG this unless someone can give a nonvisual
feature that the pager makes available that can't be done via direct
window manager access. I think focusing the pager should just give a
tooltip like "mini-display of windows on the screen" and there should
be no navigation of the subparts of the pager.
Comment 6 Rajkumar 2002-03-21 20:45:47 UTC
Created attachment 7298 [details]
Provides accessiblity support to libwnck's components used by pager applet and also adds accessibility features to pager applet.
Comment 7 Rajkumar 2002-03-21 21:16:14 UTC
The above patch has been attached in tar format as binary file, so 
"showattachment.cgi" has to be moved to *.tar to untar the patch.
Comment 8 Rajkumar 2002-03-25 17:22:41 UTC
Default button is not set in the pager applet's property box which has
to be activated on pressing enter key.
Comment 9 Rajkumar 2002-03-25 17:26:05 UTC
Created attachment 7373 [details] [review]
Patch for the above stated bug, to set a default-button for the property box.
Comment 10 Luis Villa 2002-03-29 19:55:18 UTC
Um, OK... reopening and adding PATCH keyword. Havoc, feel free to
close/reject if you don't like the patch.
Comment 11 Rajkumar 2002-03-31 00:17:54 UTC
Pls use the following updated patch for:
+ Providing accessiblity support to libwnck's components used by pager
applet
+ Adding accessibility features such as tooltips, accessible
description and atk relation to pager applet
+ Setting default button that has to be activated on pressing enter
key in the preferences dialog
The patch is added in tar format as binary file. (Ignore the previous
patches #7298, #7373)
Comment 12 Rajkumar 2002-03-31 00:22:47 UTC
Created attachment 7470 [details]
updated patch as mentioned above
Comment 13 Havoc Pennington 2002-05-13 22:05:38 UTC
Hmm, I'd forgotten about this patch. 

Is there any chance it can be in diff format instead of tar format? 
Using -N to get new files?
Comment 14 Rajkumar 2002-05-21 10:29:57 UTC
Havoc, following are the patches (3 Nos) in diff format.
These patches provides accessibility features as stated above on
"2002-03-30".

The patches are obtained using "diff -pNaur libwnck/* libwnck-new/*", 
and that for new files using "diff -pNaur /dev/null
libwnck/libwnck/access/*".
Comment 15 Rajkumar 2002-05-21 10:44:45 UTC
Created attachment 8619 [details] [review]
Patch for changes in libwnck/*
Comment 16 Rajkumar 2002-05-21 10:45:50 UTC
Created attachment 8620 [details] [review]
Patch for new files in libwnck/*
Comment 17 Rajkumar 2002-05-21 10:47:37 UTC
Created attachment 8621 [details] [review]
patch for changes in gnome-panel/applets/gen_util/*
Comment 18 Rajkumar 2002-05-21 10:54:07 UTC
Created attachment 8622 [details]
README File
Comment 19 Havoc Pennington 2002-06-03 00:11:10 UTC
Patch applied, with some fairly heavy changes (see ChangeLog). It
might be good to test the current version and report any further
issues. Should file new bugs for those issues though, rather than
reopening this one.