After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 707897 - Some stuff re translations and option parsing
Some stuff re translations and option parsing
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: wayland
unspecified
Other All
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2013-09-11 08:39 UTC by Giovanni Campagna
Modified: 2013-09-11 14:04 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add an option to run as a wayland compositor (2.62 KB, patch)
2013-09-11 08:39 UTC, Giovanni Campagna 		committed Details | Review
Fix regression in mutter-wayland translations (12.40 KB, patch)
2013-09-11 08:39 UTC, Giovanni Campagna 		committed Details | Review
Don't translate debug logs and warnings (17.66 KB, patch)
2013-09-11 08:39 UTC, Giovanni Campagna 		committed Details | Review

Description Giovanni Campagna 2013-09-11 08:39:14 UTC 
A regression in translations recently introduced by my compiler
warning cleanups, and some other stuff.
Comment 1 Giovanni Campagna 2013-09-11 08:39:17 UTC 
Created attachment 254649 [details] [review]
Add an option to run as a wayland compositor

Move the option from the mutter binary to libmutter, and
rename from --nested to --wayland.
This allows gnome-shell to drop the set_is_wayland_compositor()
call.
Comment 2 Giovanni Campagna 2013-09-11 08:39:22 UTC 
Created attachment 254650 [details] [review]
Fix regression in mutter-wayland translations

Switching meta/util.h to gi18n.h was wrong, mutter is a library
and needs gi18n-lib.h, but that cannot be included from a public
header (since it depends on config.h or command line options),
so split util.h into a public and a private part.
Comment 3 Giovanni Campagna 2013-09-11 08:39:27 UTC 
Created attachment 254651 [details] [review]
Don't translate debug logs and warnings

Warnings that are going to the journal should be not translated:
they're not user visible, and translating them would just make
bug reporting harder (as now the developers need to understand
what the warning is saying)
Comment 4 Jasper St. Pierre (not reading bugmail) 2013-09-11 13:51:22 UTC 
Review of attachment 254649 [details] [review]:

OK.
Comment 5 Jasper St. Pierre (not reading bugmail) 2013-09-11 13:51:46 UTC 
Review of attachment 254651 [details] [review]:

Of course.
Comment 6 Jasper St. Pierre (not reading bugmail) 2013-09-11 13:52:24 UTC 
Review of attachment 254650 [details] [review]:

OK.
Comment 7 Giovanni Campagna 2013-09-11 14:04:02 UTC 
Attachment 254649 [details] pushed as 4494888 - Add an option to run as a wayland compositor
Attachment 254650 [details] pushed as 7b537d6 - Fix regression in mutter-wayland translations
Attachment 254651 [details] pushed as 5ae5247 - Don't translate debug logs and warnings