After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 707798 - rtpg729depay doesn't split RTP packets into frames
rtpg729depay doesn't split RTP packets into frames
Status: RESOLVED NOTABUG
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
1.0.7
Other Linux
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-09-09 19:07 UTC by tcdgreenwood
Modified: 2013-09-09 19:27 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch based on the 1.0.7 source code (3.52 KB, patch)
2013-09-09 19:07 UTC, tcdgreenwood 		rejected Details | Review

Description tcdgreenwood 2013-09-09 19:07:03 UTC 
Created attachment 254512 [details] [review]
Patch based on the 1.0.7 source code

I believe that the g729 depayloader should split the packets into frames following the logic outlined in RFC 3551 4.5.6 G729.  The packets are made up of a number of 10 byte G729 frames followed by 0 or 1 2 byte comfort noise frames.  I have looked at other depayloaders and this function seems to be part of the depayloader.

Unfortunately I do not have a test case that I can share right now as it uses a thirdparty G.729 codec and Cisco deskphones, but the result is that G.729 cannot be decoded.

I will attach a patch for your consideration.

Thanks
Comment 1 Olivier Crête 2013-09-09 19:27:25 UTC 
Comment on attachment 254512 [details] [review]
Patch based on the 1.0.7 source code

The reason I did not to split into frames in the first place is that almost all of the GStreamer overhead is per-GstBuffer, so we want to avoid multiplying them if possible.

You decoder element should be able to separate the frames.