After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 707751 - Please remove the underscore by the gir generation --symbol-prefix=geocode_ \
Please remove the underscore by the gir generation --symbol-prefix=geocode_ \
Status: RESOLVED FIXED
Product: geocode-glib
Classification: Other
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: geocode-glib maintainer(s)
geocode-glib maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-09-09 09:03 UTC by Evgeny Bobkin
Modified: 2013-09-09 14:09 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
remove underscore (889 bytes, patch)
2013-09-09 10:34 UTC, Evgeny Bobkin 		accepted-commit_now Details | Review
remove underscore (939 bytes, patch)
2013-09-09 10:35 UTC, Evgeny Bobkin 		accepted-commit_now Details | Review
remove underscore (939 bytes, patch)
2013-09-09 14:09 UTC, Evgeny Bobkin 		committed Details | Review

Description Evgeny Bobkin 2013-09-09 09:03:30 UTC 
There is a typo landed by the gir generation

https://git.gnome.org/browse/geocode-glib/tree/geocode-glib/Makefile.am#n81

that there is an unneeded underscore in  "--symbol-prefix=geocode_".
it should be just "--symbol-prefix=geocode" instead.

Would you like me to fix and push it?
Comment 1 Evgeny Bobkin 2013-09-09 10:34:04 UTC 
Created attachment 254464 [details] [review]
remove underscore
Comment 2 Evgeny Bobkin 2013-09-09 10:35:20 UTC 
Created attachment 254465 [details] [review]
remove underscore
Comment 3 Zeeshan Ali 2013-09-09 14:01:45 UTC 
Review of attachment 254464 [details] [review]:

Thanks. 'name' sound redundant in commit log. Please do push w/ or w/o that changed..
Comment 4 Zeeshan Ali 2013-09-09 14:02:40 UTC 
Review of attachment 254465 [details] [review]:

ah, i reviewed the deprecated one. :) Same comment.
Comment 5 Evgeny Bobkin 2013-09-09 14:09:10 UTC 
Created attachment 254487 [details] [review]
remove underscore
Comment 6 Evgeny Bobkin 2013-09-09 14:09:40 UTC 
done w/ thanks.