After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 707719 - make the cancel button as center vertically
make the cancel button as center vertically
Status: RESOLVED FIXED
Product: bijiben
Classification: Applications
Component: UI
3.9.x
Other Linux
: Normal normal
: ---
Assigned To: Bijiben maintainer(s)
Bijiben maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-09-08 14:01 UTC by Yosef Or Boczko
Modified: 2013-09-13 10:24 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
selectionToolbar: make the cancel button as center vertically (900 bytes, patch)
2013-09-08 14:01 UTC, Yosef Or Boczko 		none Details | Review
selectionToolbar: make the cancel button as center vertically (1.47 KB, patch)
2013-09-08 20:53 UTC, Yosef Or Boczko 		committed Details | Review
Screenshot (23.19 KB, image/png)
2013-09-10 00:00 UTC, Yosef Or Boczko 		  Details

Description Yosef Or Boczko 2013-09-08 14:01:08 UTC 
I forgot this in bug #707219.
Comment 1 Yosef Or Boczko 2013-09-08 14:01:56 UTC 
Created attachment 254395 [details] [review]
selectionToolbar: make the cancel button as center vertically
Comment 2 Pierre-Yves Luyten 2013-09-08 20:42:29 UTC 
Actually you did not forgot, i reverted this for the Cancel button (sorry I forgot to email).

The issue i have with valign is the heigth. If this text button is aligned, search button will not request the same size (Cancel button is smaller).
Comment 3 Yosef Or Boczko 2013-09-08 20:47:53 UTC 
Oh, so need use GtkSizeGroup for this.
Wait for patch :-)

Anyway, must to set the valign of the close
button to center.
See for example in gnome-documents.
Comment 4 Yosef Or Boczko 2013-09-08 20:53:58 UTC 
Created attachment 254434 [details] [review]
selectionToolbar: make the cancel button as center vertically
Comment 5 Pierre-Yves Luyten 2013-09-08 21:49:08 UTC 
Review of attachment 254434 [details] [review]:

Perfect, please commit
Comment 6 Yosef Or Boczko 2013-09-08 21:55:46 UTC 
Review of attachment 254434 [details] [review]:

pushed as 04f76d5d1329248ba1438e0587d8c86e27c942cd - selectionToolbar: make the cancel button as center vertically
Comment 7 Pierre-Yves Luyten 2013-09-08 22:10:52 UTC 
I just applied the same GtkSizeGroup fix to "New" button
Comment 8 Yosef Or Boczko 2013-09-08 22:47:39 UTC 
Have problem - this not compatible to the currently design:
https://wiki.gnome.org/GnomeOS/Design/Whiteboards/SelectionPattern

(Now, the buttons too high).
Comment 9 Pierre-Yves Luyten 2013-09-09 23:58:35 UTC 
if you run gtk+ master, can you provide a screen with default theme / fonts?
Comment 10 Yosef Or Boczko 2013-09-10 00:00:54 UTC 
Created attachment 254537 [details]
Screenshot