Created attachment 254306 [details] [review]
fix as-scrub-include so that it works for the non-gcc case

Building gst-plugins-ugly 0.10.19 on x86_64-pc-solaris2.11 (OpenIndiana oi151a8) with the Oracle Studio 12.3 compiler toolchain.

When running configure, it outputs:

checking for GLIB... yes
"s#-I[No ##
": 1: unbalanced brackets ([])
checking for ORC... no

I eventually tracked that down to the AS_SCRUB_INCLUDE, which is attempting to
execute

  INCLUDE_DIRS=`echo | cpp -v 2>&1`

      INCLUDE_DIRS=`echo $INCLUDE_DIRS | sed -e 's/.*<...> search starts here://' | sed -e 's/End of search list.*//'`
  for dir in $INCLUDE_DIRS; do
        GIVEN_CFLAGS=`echo $GIVEN_CFLAGS | sed -e "s#-I$dir ##"`
  done


That's not portable for a couple reasons -- it expects cpp to exist, be in the person running configure's PATH, and to have GNU cpp syntax.

Some platforms don't even have a separate cpp anymore, they just use "cc -E", which configure correctly detects.

What should probably happen is something like

if test X"$GCC" = X"yes" ; then
  INCLUDE_DIRS=`echo | cpp -v 2>&1`
else
  dnl a suitable default, so that $INCLUDE_DIRS isn't empty later
  INCLUDE_DIRS=/usr/include
fi

Alternately, the entire check could just be skipped if not using gcc, as it
appears to be coded just to work around an issue with some versions of gcc.

One possible patch is attached.