GNOME Bugzilla – Bug 707642
Missing direction annotations in TotemPlPlaylist
Last modified: 2013-09-23 06:36:27 UTC
The functions append, prepend and others in plparse/totem-pl-playlist.c need (in) and (out) annotations for the iter parameters. Also, the file is not being parsed by g-ir-scanner, making the other annotations for this file useless.
Created attachment 254274 [details] [review] build: Add totem-pl-playlist.c to plparser_sources The source file totem-pl-playlist.c is not being parsed by g-ir-scanner because it is missing in instrospection_sources. This will implicitly add it to that variable.
Created attachment 254275 [details] [review] plparse: Add missing direction annotations to TotemPlPlaylist
Review of attachment 254274 [details] [review]: Fine.
Review of attachment 254275 [details] [review]: That looks fine. Did you test with anything?
Thanks for the fast review :D (In reply to comment #4) > That looks fine. Did you test with anything? Some of it, especially append. We need this for gnome-music playlists, and the branch for it is in: https://github.com/gnome-prototypes-team/gnome-music/tree/playlists I'll commit them later, I'll try to do more tests and might add more patches to this bug. By the way, is totem-pl-parser going to have a release on 3.9.92? It would be great if there would be, so that we could have playlists on the next release :D
(In reply to comment #5) > Thanks for the fast review :D > > (In reply to comment #4) > > That looks fine. Did you test with anything? > > Some of it, especially append. We need this for gnome-music playlists, and the > branch for it is in: > > https://github.com/gnome-prototypes-team/gnome-music/tree/playlists > > I'll commit them later, I'll try to do more tests and might add more patches to > this bug. Great. > By the way, is totem-pl-parser going to have a release on 3.9.92? It would be > great if there would be, so that we could have playlists on the next release :D If either Philip or I get time, yes.
After testing with JavaScript, I found out that more changes are needed to make it work there. There is no iter copy function that GJS needs. But I think adding a new function is too late for 3.10, and the API/ABI break is already in effect. Also, although I haven't found any other packages dependent on the gobject-introspection of totem-pl-parser yet, these changes might break something. Also, this will increase gnome-music dependencies - we are trying to be compatible with 3.8 during this cycle. All backwards compatibility will be dropped next cycle. The C-like approach works in Python. So I decided that I'll just do the other necessary changes and attach new patches here on the next cycle, 3.12.
Attachment 254274 [details] pushed as 56f9ffa - build: Add totem-pl-playlist.c to plparser_sources Attachment 254275 [details] pushed as d35e1d3 - plparse: Add missing direction annotations to TotemPlPlaylist