After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 707632 - MPRIS Close command is broken
MPRIS Close command is broken
Status: RESOLVED FIXED
Product: gnome-music
Classification: Applications
Component: general
3.9.x
Other Linux
: Normal normal
: 3.10
Assigned To: gnome-music-maint
gnome-music-maint
Depends on:
Blocks:
 
 
Reported: 2013-09-06 14:00 UTC by Arnel Borja
Modified: 2013-09-16 08:42 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
application: Fix close command for MPRIS (868 bytes, patch)
2013-09-15 05:23 UTC, Arnel Borja
committed Details | Review

Description Arnel Borja 2013-09-06 14:00:56 UTC
The changes made to the application menu broke it.
Comment 1 Arnel Borja 2013-09-07 05:22:03 UTC
This should be easy and important for 3.10.
Comment 2 Arnel Borja 2013-09-15 05:23:35 UTC
Created attachment 254956 [details] [review]
application: Fix close command for MPRIS

The parameters of quit() method changed but was not updated in MPRIS.
Set the new parameters as optional.
Comment 3 Vadim Rutkovsky 2013-09-16 07:51:41 UTC
Review of attachment 254956 [details] [review]:

Worked for me, thanks
Comment 4 Arnel Borja 2013-09-16 08:42:24 UTC
Comment on attachment 254956 [details] [review]
application: Fix close command for MPRIS

Committed as d5a57fbf.